v3.trusts.update() should raise a MethodNotImplemented error (not HttpNotImplemented)

Bug #1325755 reported by Rodrigo Duarte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Undecided
Rodrigo Duarte

Bug Description

The client method should raise a Client error and be consistent with another Managers, like RoleAssignmentsManager: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/role_assignments.py#L94

summary: - trusts.update() should raise a MethodNotImplemented error (not
+ v3.trusts.update() should raise a MethodNotImplemented error (not
HttpNotImplemented)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97355

Changed in python-keystoneclient:
assignee: nobody → Rodrigo Duarte (rodrigodsousa)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/97355
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=53a175e7c6aca860f9a9eaa4af6d9801d0cfdba4
Submitter: Jenkins
Branch: master

commit 53a175e7c6aca860f9a9eaa4af6d9801d0cfdba4
Author: Rodrigo Duarte Sousa <email address hidden>
Date: Mon Jun 2 18:44:59 2014 -0300

    Changes exception raised by v3.trusts.update()

    The client should raise a Client error, instead of
    a Server one.

    The MethodNotImplemented exeception handles calls
    made to not supported methods.

    Change-Id: I0e2a8c5e1e53b0f17b886aa693c922bc193bb882
    Closes-Bug: #1325755

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.10.0
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.