vmware: volume created on a cluster having an ESX 5.1 host cannot be attached to instance on ESXi 5.0 host

[Unmesh Gurjar]

Steps to reproduce:
Pre-requisite: Create two clusters in a vCenter, such that one cluster has a ESX 5.1 host and another cluster with ESX 5.0 host.

1. Spawn an instance in cluster with ESX 5.1 host.
2. Create a VMFS backed volume and attach to the instance created in #1 above.
3. Detach the volume from the instance.
4. Spawn another instance in cluster with ESX 5.0 host.
5. Attach the volume created in #2 above to the instance just created in #4 (instance on ESX 5.0 host).

Actual Result:
Volume attachment fails in #5 with a "server incompatibility" error.

Expected Behavior:
VMFS volume should get attached successfully.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/97248

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97248
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a23a80aeb8a35cd421fe63c984bf64f24f0dcb3c
Submitter: Jenkins
Branch: master

commit a23a80aeb8a35cd421fe63c984bf64f24f0dcb3c
Author: Unmesh Gurjar <email address hidden>
Date: Mon Jun 2 18:44:55 2014 +0530

    vmware: Fixes VMDK volume incompatibility issue

    VMDK volume created in a cluster having ESXi 5.1 host has a high
    hardware version i.e. 9; hence, fails when attached to instance
    on an ESXi 5.0 host. This patch sets the hardware version to 8,
    so that the volume can be attached to instances on any ESXi host
    starting version 5.0 and above.

    Change-Id: Ia750fd1183334005a834eb49be767451d87b338c
    Closes-Bug: #1325586