[regression][#60] cannot change greeter's background

[Jean-Baptiste Lallement]

On build #60 (maybe before, because I upgraded from #55 to #60) the background image of the greeter cannot be changed

TEST CASE
1. Go to system-settings/background
2. Select "Same background for both" and tap "Home screen"
3. Press "Photo/Image" to go to the gallery
4. Select a custom background (i.e take a picture with the camera), and press "Pick"
5. Back to the preview screen, press "Set" to apply it to the greeter and home
6. Lock the screen

EXPECTED RESULT
Background image of the greeter is updated with the custom image

ACTUAL RESULT
It still uses the default Ubuntu background

ProblemType: Bug
DistroRelease: Ubuntu 14.10
Package: unity8-greeter 7.87+14.10.20140530.1-0ubuntu1
Uname: Linux 3.4.0-5-mako armv7l
ApportVersion: 2.14.3-0ubuntu1
Architecture: armhf
Date: Mon Jun 2 11:17:40 2014
InstallationDate: Installed on 2014-06-02 (0 days ago)
InstallationMedia: Ubuntu Utopic Unicorn (development branch) - armhf (20140602)
SourcePackage: unity8
UpgradeStatus: No upgrade log present (probably fresh install)

[Jean-Baptiste Lallement (jibel)]

After selecting a wallpaper, when I press 'Set' to confirm the change the following warning is printed in the lg file application-legacy-ubuntu-system-settings-.log:
2014-06-02 11:37:01,950 - WARNING - file:///usr/share/ubuntu/settings/system/qml-plugins/background/Wallpapers.qml:124: TypeError: Cannot read property 'state' of undefined

[Michael Terry (mterry)]

I can't reproduce on r64. Can you confirm with image 64? There were some temporary oddities with dbus in the user's session that may have caused this.

[Brendan Donegan (brendan-donegan)]

I can confirm it with image 64. I see the same error as jibel too in that log file. My image is freshly flashed.

[Michael Terry (mterry)]

Oh, I see it now too. I know what's happening. Working on it.

[Michael Terry (mterry)]

System Settings should be using a background file location that the greeter can read, not a location inside the user's directory. This is what the XDG_GREETER_DATA_DIR variable is for. It's a folder where the user can share larger files with the greeter.

I fixed telephony-service to use that folder for avatars, but I overlooked the background file use case when splitting the greeter, sorry.

[Michael Terry (mterry)]

Laney, did you mean to set this Won't Fix? If so, why?

[Iain Lane (laney)]

On Wed, Jun 04, 2014 at 09:49:16PM -0000, Michael Terry wrote:
> Laney, did you mean to set this Won't Fix? If so, why?

No, oops

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.1+14.10.20140606-0ubuntu1

---------------
ubuntu-system-settings (0.1+14.10.20140606-0ubuntu1) utopic; urgency=low

  [ Michael Terry ]
  * Use XDG_GREETER_DATA_DIR to store background files in a folder that
    the greeter can also read. This fixes the recent regression in not
    being able to choose a ContentHub file for the welcome screen. (LP:
    #1325505)

  [ Iain Lane ]
  * Inline setUpImages(), otherwise the function call doesn't do
    anything.

  [ Brendan Donegan ]
  * Make test_tz_list_initially_empty more robust by using
    wait_select_single instead of select_single to get the label. (LP:
    #1319711)
 -- Ubuntu daily release <email address hidden> Fri, 06 Jun 2014 14:39:39 +0000