[dashboard] Exception in pagination during viewing catalog

Bug #1325362 reported by Serg Melikyan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Critical
Timur Sufiev

Bug Description

Traceback:
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/core/handlers/base.py" in get_response
  115. response = callback(request, *callback_args, **callback_kwargs)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/horizon/decorators.py" in dec
  38. return view_func(request, *args, **kwargs)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/horizon/decorators.py" in dec
  54. return view_func(request, *args, **kwargs)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/horizon/decorators.py" in dec
  38. return view_func(request, *args, **kwargs)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/views/generic/base.py" in view
  68. return self.dispatch(request, *args, **kwargs)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/views/generic/base.py" in dispatch
  86. return handler(request, *args, **kwargs)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/views/generic/list.py" in get
  139. context = self.get_context_data(object_list=self.object_list)
File "/home/sad/Projects/murano-dashboard/muranodashboard/catalog/views.py" in get_context_data
  333. context = super(IndexView, self).get_context_data(**kwargs)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/views/generic/list.py" in get_context_data
  99. paginator, page, queryset, is_paginated = self.paginate_queryset(queryset, page_size)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/views/generic/list.py" in paginate_queryset
  53. page = paginator.page(page_number)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/core/paginator.py" in page
  40. number = self.validate_number(number)
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/core/paginator.py" in validate_number
  31. if number > self.num_pages:
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/core/paginator.py" in _get_num_pages
  63. if self.count == 0 and not self.allow_empty_first_page:
File "/home/sad/Projects/murano-dashboard/.venv/local/lib/python2.7/site-packages/django/core/paginator.py" in _get_count

Changed in murano:
assignee: nobody → Timur Sufiev (tsufiev-x)
milestone: none → juno-1
importance: Undecided → Critical
summary: - [dashboad] Exception in pagination during viewing catalog
+ [dashboard] Exception in pagination during viewing catalog
Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/93941
Committed: https://git.openstack.org/cgit/stackforge/murano-dashboard/commit/?id=57d32347cd0d3d847f2da01ff608e11ddd1137d2
Submitter: Jenkins
Branch: master

commit 57d32347cd0d3d847f2da01ff608e11ddd1137d2
Author: Timur Sufiev <email address hidden>
Date: Fri May 16 18:56:28 2014 +0400

    Fix AppCatalog to use 'marker' attribute for pagination

    Glance-like interface provides us with 'has_more_data' flag and
    'marker' pointing to the next page data set. That means that
    AppCatalog should drop link to previous page of Applications as well
    as current page number - they both are not supported by standard OS
    api.

    Also:
    * do not pass category as a part of murano:index url, pass it as a
      part of query-string (as well as marker);
    * refactor filling 'Latest Apps' section: inside get_context_data()
      remove invalid app_id-s from session (i.e. because those packages
      were deleted). This change is needed because we may no longer know
      all existing packages after a single request to AppCatalog
      IndexView.

    Change-Id: Ia0f4adb5657de9fba67733705268eb80684c656c
    Implements: blueprint normalize-dashboard-pagination
    Closes-Bug: #1307990
    Closes-Bug: #1325362

Changed in murano:
status: In Progress → Fix Committed
ruhe (ruhe)
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.