Remove Blue focus for Search & Library on Mac

Bug #1325229 reported by Lee Matos
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Lee Matos

Bug Description

I'd be super cool if mixxx didn't have a blue QFocusFrame on the searchbox and library tree. Most themes implement their own focus and a quick google shows this is a Mac issue. Looks like the fix is to "setAttribute(Qt.WA_MacShowFocusRect, 0)" I'm not sure where to apply that.

Tags: usability
Lee Matos (lbot)
description: updated
Revision history for this message
Lee Matos (lbot) wrote :

It looks like for searchbox it'd happen here:

https://github.com/mixxxdj/mixxx/blob/master/src/widget/wsearchlineedit.cpp

and library tree:

https://github.com/mixxxdj/mixxx/blob/master/src/widget/wlibrarysidebar.cpp

Or their respective header files. I'm not a C guy. :)

Lee Matos (lbot)
Changed in mixxx:
assignee: nobody → Lee (lbot)
status: New → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Lee Matos (lbot) wrote :

I've submitted a pull request on github to get this merged. \o/

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi Lee,

You becoming a C Guy? Fine :-)

I cannot check your patch, because I am not on Mac Hardware.
But If it is finally checked, you need to become Mixxx contributor.

Please sign:
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
and comment here when done.

Thank you for your contributions!

Daniel

Revision history for this message
Lee Matos (lbot) wrote :

Signed and Thanks!

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hi Lee,

Thanks for the patch and welcome to Mixxx development!

Could you explain why you want to remove the focus highlight? This is a usability feature that helps let you know the searchbox is highlighted (and draws attention to the fact that your keyboard presses are being captured by the search box).

Revision history for this message
Lee Matos (lbot) wrote :

Hey RJ,

My reasoning is twofold:

1) The cornerstone of Mixx for me is theming. The QT implementation of Mac border focus looks bad if you use any margin. It highlights the margin as well. I don't like things that look bad. :)

2) There is no usability loss as you can define a ::focus style on the element to dictate it has focus. I've attached a photo of my build running an the default deere skin with the focus working by highlighting the box orange. It's still very very clear that the element has focus and it gives the themer more control. I'd even go as far to suspect that if someone really wanted it they could custom add the blue back with some outline rules a la CSS.

As far as I understand, this also makes mixxx theme behavior the same across platforms which as a themer makes me happy.

Revision history for this message
Lee Matos (lbot) wrote :

Here's an example of what I mean with regards to margin weirdness. The library sidebar has a top margin that the highlight includes as part of the element. I think it makes Mixxx look unpolished.

Revision history for this message
Lee Matos (lbot) wrote :

Err. Let's try that again. This is with a build directly pulled from GH today no changes by me

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks for the explanation Lee -- I didn't realize you could style it.

Changed in mixxx:
milestone: none → 1.12.0
importance: Undecided → Low
tags: added: usability
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7486

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.