Master node installation should not delete existing partitions on target disk silently

[Miroslav Anashkin]

In case already installed master node is occasionally booted from Fuel installation media, it's installation process will automatically redeploy the existing master node with complete disk wipe.
It is quite dangerous.
Let master node installation asks user to confirm target disk wipe, but only in case some partitions already exist on target disk.
If there are no partitions - let it proceed with installation silently.

[Mike Scherbakov (mihgen)]

This will become an issue for automated testing on bare metal. Let's think how we can avoid it.

[Aleksandr Didenko (adidenko)]

We can add new variable (via kernel params) to force formatting without asking for confirmation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/97227

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97227
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=12113261e20992ebf31d259ced4ee3358befd977
Submitter: Jenkins
Branch: master

commit 12113261e20992ebf31d259ced4ee3358befd977
Author: Aleksandr Didenko <email address hidden>
Date: Mon Jun 2 15:21:12 2014 +0300

    Confirm disk re-partitioning before proceeding

    Ask for a confirmation before Fuel installation on a drive with
    existing partition table.

    New kickstart kernel parameter:
      - "forceformat" - (yes/no) defaul is "no". Set to "yes" if you
                        want to format chosen drive automatically.

    For example, if you add "installdrive=sda forceformat=yes" to the
    kernel parameters line in Grub menu, then "sda" drive will be
    formatted automatically and Fuel will be installed on it.

    Change-Id: I0dfcb1d461748fe6b0698f125201b730d63e41d4
    Closes-bug: #1325068

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/98417

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/4.1
Review: https://review.openstack.org/98430

[Dmitry Borodaenko (angdraug)]

This is a feature, not a bug. What is it doing in stable releases?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98417
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=860c40df85ad07b4d6782db3d6714acdef8fc8fb
Submitter: Jenkins
Branch: stable/5.0

commit 860c40df85ad07b4d6782db3d6714acdef8fc8fb
Author: Aleksandr Didenko <email address hidden>
Date: Mon Jun 2 15:21:12 2014 +0300

    Confirm disk re-partitioning before proceeding

    Ask for a confirmation before Fuel installation on a drive with
    existing partition table.

    New kickstart kernel parameter:
      - "forceformat" - (yes/no) defaul is "no". Set to "yes" if you
                        want to format chosen drive automatically.

    For example, if you add "installdrive=sda forceformat=yes" to the
    kernel parameters line in Grub menu, then "sda" drive will be
    formatted automatically and Fuel will be installed on it.

    Change-Id: I0dfcb1d461748fe6b0698f125201b730d63e41d4
    Closes-bug: #1325068
    (cherry picked from commit 12113261e20992ebf31d259ced4ee3358befd977)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98430
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=180f6397eceb3e1b1b96cea419e80d4909d73ca9
Submitter: Jenkins
Branch: stable/4.1

commit 180f6397eceb3e1b1b96cea419e80d4909d73ca9
Author: Aleksandr Didenko <email address hidden>
Date: Mon Jun 2 15:21:12 2014 +0300

    Confirm disk re-partitioning before proceeding

    Ask for a confirmation before Fuel installation on a drive with
    existing partition table.

    New kickstart kernel parameter:
      - "forceformat" - (yes/no) defaul is "no". Set to "yes" if you
                        want to format chosen drive automatically.

    For example, if you add "installdrive=sda forceformat=yes" to the
    kernel parameters line in Grub menu, then "sda" drive will be
    formatted automatically and Fuel will be installed on it.

    Change-Id: I0dfcb1d461748fe6b0698f125201b730d63e41d4
    Closes-bug: #1325068

[Meg McRoberts (dreidellhasa)]

Added to "Fixed Issues" in the 5.0.1 Release Notes.