libdbi deprecation warnings when building Evergreen

[Chris Sharp]

When building Evergreen Master on Ubuntu 14.04 (libdbi-0.8.4), I see the following warnings:

oils_sql.c:157:2: warning: 'dbi_initialize' is deprecated (declared at /usr/include/dbi/dbi.h:169) [-Wdeprecated-declarations]
  if( dbi_initialize( NULL ) == -1 ) {
  ^
oils_sql.c:171:2: warning: 'dbi_conn_new' is deprecated (declared at /usr/include/dbi/dbi.h:199) [-Wdeprecated-declarations]
  dbi_conn handle = dbi_conn_new( driver );
  ^
test_json_query.c:143:2: warning: ‘dbi_initialize’ is deprecated (declared at /usr/include/dbi/dbi.h:169) [-Wdeprecated-declarations]
  if( dbi_initialize( NULL ) < 0 ) {
  ^
test_json_query.c:148:2: warning: ‘dbi_conn_new’ is deprecated (declared at /usr/include/dbi/dbi.h:199) [-Wdeprecated-declarations]
  dbi_conn conn = dbi_conn_new( "pgsql" ); // change string if ever necessary
  ^
test_json_query.c:151:3: warning: ‘dbi_shutdown’ is deprecated (declared at /usr/include/dbi/dbi.h:171) [-Wdeprecated-declarations]
   dbi_shutdown();
   ^
test_json_query.c:166:2: warning: ‘dbi_shutdown’ is deprecated (declared at /usr/include/dbi/dbi.h:171) [-Wdeprecated-declarations]
  dbi_shutdown();
  ^
test_qstore.c:290:2: warning: ‘dbi_initialize’ is deprecated (declared at /usr/include/dbi/dbi.h:169) [-Wdeprecated-declarations]
  dbi_initialize( NULL );
  ^
test_qstore.c:291:2: warning: ‘dbi_conn_new’ is deprecated (declared at /usr/include/dbi/dbi.h:199) [-Wdeprecated-declarations]
  dbi_conn dbhandle = dbi_conn_new( opts->driver );

According to the Programmers Reference for LibDBI, there are replacement functions available (see http://libdbi.sourceforge.net/docs/programmers-guide/reference-core.html).

[Chris Sharp (chrissharp123)]

Also libdbi.sourceforge.net/docs/programmers-guide/reference-conn.html

[Galen Charlton (gmc)]

Looks like we're not using libdbi's instance stuff, so it looks like that just moving from dbi_foo() to dbi_foo_r() should take care of it. I think all of the supported distributions are using versions of libdbi new enough to have the *_r versions.

[Galen Charlton (gmc)]

Whoops, I got it backwards - with the new functions, looks like we'll _have_ to start tracking dbi_inst handles.