Bug in table edit of forms editor

[Benno Luthiger]

If the text in a table cell gets decorated, this will make the forms editor throwing an "AttributeError: strip" when the document in placed in a hierarchy somewhere under a folder with the ID 'data'.

Reason:
The problem is caused by the script "SilvaDocument/widgets/element/table_elements/row/render_field.py". On line 25, there's the following condition:
---
    if (len(node.childNodes) == 1 and hasattr(node.childNodes[0], 'data') and
            len(node.childNodes[0].data.strip()) == 0):
---
This condition acquires the object 'data' and calls to strip() method on it. This is correct if 'data' is a field returning a string. However, if hasattr(node.childNodes[0], 'data') acquires a SilvaFolder, the command SilvaFolder.strip() will fail.

Suggested fix:
Use 'node.childNodes[0].aq_explicit instead:
---
    if (len(node.childNodes) == 1 and hasattr(node.childNodes[0].aq_explicit, 'data') and
            len(node.childNodes[0].data.strip()) == 0):
---

Does this solution have any unintended side effects?

Regards,
Benno

[Benno Luthiger (benno-luthiger)]

Will a fix of this bug ported to the Silva 1.5 branch?

[Eric Casteleijn (thisfred)]

I'll check this in to all branches and ask someone to do some testing.

[Eric Casteleijn (thisfred)]

Wim could you test this in 1.6 and 1.5 after the sprint?

[Wim Boucquaert (wim-boucquaert)]

thisfred wrote:
> Wim could you test this in 1.6 and 1.5 after the sprint?
>
> ** Changed in: silvadocument (upstream)
> Assignee: thisfred => Wim Boucquaert
>
>
Ok thisfred tagged and put on my todo list

[Eric Casteleijn (thisfred)]

I unfortunately checked in a stupid typo with this fix (aq_explixit instead of aq_explicit) and apparently testing didn't catch it. It's fixed on all branches and trunk now, and is in SilvaDocument-2.0.2

[Kit Blake (kitblake)]

Explicit is better than explixit, hyuk, hyuk, hyuk