make install fails if running strip

[Peter Chubb]

I do:
   ./configure --target-list=arm-softmmu
   make
  sudo make install

and see:
install -d -m 0755 "/usr/local/bin"
libtool --quiet --mode=install install -c -m 0755 qemu-ga qemu-nbd qemu-img qemu-io fsdev/virtfs-proxy-helper "/usr/local/bin"
strip "/usr/local/bin/qemu-ga" "/usr/local/bin/qemu-nbd" "/usr/local/bin/qemu-img" "/usr/local/bin/qemu-io" "/usr/local/bin/fsdev/virtfs-proxy-helper"
strip: '/usr/local/bin/fsdev/virtfs-proxy-helper': No such file
Makefile:379: recipe for target 'install' failed
make: *** [install] Error 1

Host is Odroid-XU running Debian Jessie.
Source is at d7d3d6092cb7edc75dc49fb90c86dd5425ab4805 Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter'

libtool version 2.4.2-1.7 armhf

[Peter Maydell (pmaydell)]

Not sure this is really ARM related, is it? It looks like it will happen any time we do a make install and we're using strip and we've built something in some subdir like fsdev.

> ** Patch added: "Probably wrong fix."
> https://bugs.launchpad.net/bugs/1324724/+attachment/4122442/+files/fix.patch

Looks fairly reasonable to me. I think I'd do both places the same way you did the libexec case, though (without the extra make variable).

[Peter Chubb (peter-chubb-1)]

The libexec case doesn't actually work, which is why IO switched to a separate variable. One of the reasons I said the patch is probably wrong.

I suspect we need something like
$(STRIP) $(addprefix $(DESTDIR)/$(BINDIR), $(notdir ${TOOLS)))

And I didn't see the problem on x86_64, only on armhf. I think x86_64 doesn't need the fsdev helper.

[Peter Maydell (pmaydell)]

This was fixed by commit 0d6594261 back in 2014.