physical_resource_name of Nova server should not be overriden

[Qiming Teng]

When physical_resource_name of a Nova server is overridden, and the Nova server carries SOFTWARE_CONFIG as its user_data_format, we have to make sure the 'name' property of the server is unique across stack user domain. This is because Keystone will use the (stack_user_domain, resource_name) pair as a unique key for the user table. This would be a burden for users, and it cannot be safely guaranteed.

We need a fix to the physical_resource_name of a Nova server so that it can be 'automatically unique' across a stack_user_domain.

[Steve Baker (steve-stevebaker)]

I think having the resource name in the created user is only a convenience to indicate what that user belongs to. I'm fairly certain that these users are only ever accessed via their UUID, not their username.

Either Server shouldn't override physical_resource_name, or StackUser should call the actual Resource.physical_resource_name

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96669
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d85bbc9a4d12d7534ae8c19c7afded34f434c9c9
Submitter: Jenkins
Branch: master

commit d85bbc9a4d12d7534ae8c19c7afded34f434c9c9
Author: tengqim <email address hidden>
Date: Fri May 30 13:03:56 2014 +0800

    Fix physical_resource_name for Nova server

    This patch fixes the problem caused by the overridden
    physical_resource_name() in OS::Nova::Server resource. If the name
    assigned to the Server resource is used for Keystone user creation,
    there is a higher possibility of name conflicts.

    Change-Id: I5eff496aef8949db9c1f9865e8de33d2b58c7a7f
    Closes-Bug: #1324499