TAPNComposerWithGUI

Bug #1324234 reported by Jiri Srba
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
TAPAAL
Fix Released
High
Thomas Stig Jacobsen

Bug Description

We now use both TAPNComposer and TAPNComposerWithGUI (earlier called TAPNComposerExtended).

The older TAPNComposer should be replaced by the newer one (and the calls to the old one should be
updated with the GUI data layer in order to match the new constructor).

Related branches

Revision history for this message
Thomas Stig Jacobsen (tsja10) wrote :

There are some problems with fixing this bug.
As pointed out in the merge of tapaal-approx into tapaal:

Essentially the new composer takes a HashMap<TimedArcPetriNet, DataLayer> guiModel in it's constructor so it cannot be used everywhere either since not everywhere a guiModel is available.

I will propose a solution to this later today.

Revision history for this message
Thomas Stig Jacobsen (tsja10) wrote :

As I see it, there are two possible solutions to this and we can use the new TAPNComposerWithGUI everywhere in the code in either case.

Solution 1: When a TAPNComposerWithGUI is initialized without a guiModel we will use a TAPNComposer instead.

Solution 2: TAPNComposerWithGUI can be rewritten to only create a new guiModel if the old one was given.

I am working on solution number 2 right now.

Revision history for this message
Thomas Stig Jacobsen (tsja10) wrote :

I have not committed a fix in the linked branch which fixes the problem.

TAPAAL Janitor (tapaal)
Changed in tapaal:
status: New → Fix Committed
Changed in tapaal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.