dockerctl defects (list, shell, license)

[Andrew Woodward]

dockerctl lacks a 'list' function this lack is further compounded by 'shell' only taking names like "cobbler", "nailgun", ... which don't directly match what is visible in 'docker ps'

'dockerctl list' should list containers names and possibly simple status similar to 'virsh list'

'dockerctl shell' should take container names from 'list' as well as the docker ID from 'docker ps'

lastly, looking into /usr/bin/dockerctl and /usr/share/dockerctl/functions neither have a copyright or license statement which are necessary

[Matthew Mosesohn (raytrac3r)]

Andrew, I knew there was a feature gap in dockerctl, and it was originally meant to be a temporary solution that wouldn't reach release, but it happened. I'm happy to accommodate both of those feature requests, but would you like any other capabilities that would make administration easier?

License should go in /usr/share/docs and dockerctl should be an RPM with the license properly flagged there. We can catch that in the next release cycle for sure.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96776

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96794

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96794
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=1cfc5e883f409084c2083751760e02a5a45fc5ae
Submitter: Jenkins
Branch: master

commit 1cfc5e883f409084c2083751760e02a5a45fc5ae
Author: Matthew Mosesohn <email address hidden>
Date: Fri May 30 18:50:10 2014 +0400

    Increase flexibility of dockerctl shell

    new internal function get_container_id can
    look up container ID from many identifiers.

    dockerctl shell can now accept the following
    identifiers for a container:
      short name (cobbler)
      long name (fuel-core-5.1-cobbler)
      short id (e506c54d80d1)
      long id (64 chars)

    Change-Id: Ia54a2a905a060848d773a9c81bbe4df1f8991d82
    Partial-Bug: #1324227

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96776
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=f188b1204bad8c78c08150c792d61202c797d176
Submitter: Jenkins
Branch: master

commit f188b1204bad8c78c08150c792d61202c797d176
Author: Matthew Mosesohn <email address hidden>
Date: Fri May 30 18:34:41 2014 +0400

    Add list function to dockerctl

    New dockerctl functions:
    dockerctl list - outputs short name of each
    available container
    dockerctl list -l - outputs short name, image name,
    status, and long container name of each container

    Partial-Bug: #1324227

    Change-Id: I30646db6d04bf8ff1f232c7e3021d790ec5d566a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/114494

[Bogdan Dobrelya (bogdando)]

https://review.openstack.org/#/c/114497/

[Bogdan Dobrelya (bogdando)]

https://review.openstack.org/#/c/98994/

[Dmitry Borodaenko (angdraug)]

Why is this targeted for 5.0.x if it's a Medium bug (and really a feature)?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: stable/5.0
Review: https://review.openstack.org/114494

[Anastasia Palkina (apalkina)]

Verified this bug on ISO #11

"build_id": "2014-09-17_21-40-34", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "11", "auth_required": true, "api": "1.0", "nailgun_sha": "eb8f2b358ea4bb7eb0b2a0075e7ad3d3a905db0d", "production": "docker", "fuelmain_sha": "8ef433e939425eabd1034c0b70e90bdf888b69fd", "astute_sha": "f5fbd89d1e0e1f22ef9ab2af26da5ffbfbf24b13", "feature_groups": ["mirantis"], "release": "5.1", "release_versions": {"2014.1.1-5.1": {"VERSION": {"build_id": "2014-09-17_21-40-34", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "11", "api": "1.0", "nailgun_sha": "eb8f2b358ea4bb7eb0b2a0075e7ad3d3a905db0d", "production": "docker", "fuelmain_sha": "8ef433e939425eabd1034c0b70e90bdf888b69fd", "astute_sha": "f5fbd89d1e0e1f22ef9ab2af26da5ffbfbf24b13", "feature_groups": ["mirantis"], "release": "5.1", "fuellib_sha": "d9b16846e54f76c8ebe7764d2b5b8231d6b25079"}}}, "fuellib_sha": "d9b16846e54f76c8ebe7764d2b5b8231d6b25079"

License is missing.

I don't see license file in /usr/share/dockerctl/functions or /usr/share/doc/

[Matthew Mosesohn (raytrac3r)]

Adding license for 6.0

[Dmitry Ilyin (idv1985)]

Why didn't you write dockerctl in python/ruby. Long shell scripts can be a nightmare to maintain and now you are going to face it...

[Stanislaw Bogatkin (sbogatkin)]

Matthew, can you, please, add license for current 6.1 branch? It seems quite easy and will close this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/154810

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154810
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=c8d91164c8acd8463eae8c964074d910feae58e8
Submitter: Jenkins
Branch: master

commit c8d91164c8acd8463eae8c964074d910feae58e8
Author: Matthew Mosesohn <email address hidden>
Date: Wed Feb 11 13:18:24 2015 +0300

    Add license to dockerctl scripts

    Change-Id: I7a50dc05cdb9bd18c21884fe8a34946d20f081ec
    Closes-Bug: #1324227

[Anastasia Palkina (apalkina)]

Verified on ISO #114

"build_id": "2015-02-11_22-54-44", "ostf_sha": "f9c37d0876141e1550eb4e703a8e500cd463282f", "build_number": "114", "release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-02-11_22-54-44", "ostf_sha": "f9c37d0876141e1550eb4e703a8e500cd463282f", "build_number": "114", "api": "1.0", "nailgun_sha": "78e1fa50e38efc1001ddfe0565a55e9e176ff5f6", "production": "docker", "python-fuelclient_sha": "312c4fe36cd09a8be63c8ad3541b4cd9ab04defc", "astute_sha": "2159855ba7b82956ac0787a4e7be053105c4c1f1", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "c3f3bf4c1f601b600fb8bd8537ade9d1f13fe475", "fuellib_sha": "592df3ba1dbfba6c6c84f90ff36b0c4c697934d3"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "78e1fa50e38efc1001ddfe0565a55e9e176ff5f6", "production": "docker", "python-fuelclient_sha": "312c4fe36cd09a8be63c8ad3541b4cd9ab04defc", "astute_sha": "2159855ba7b82956ac0787a4e7be053105c4c1f1", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "c3f3bf4c1f601b600fb8bd8537ade9d1f13fe475", "fuellib_sha": "592df3ba1dbfba6c6c84f90ff36b0c4c697934d3"