keyerror while updating dhcp port

[Armando Migliaccio]

When an update for a dhcp port fails, a keyerror on missing network_id while attempting to log a trace masks the underlying exception. An example is here:

http://logs.openstack.org/91/94891/1/check/check-tempest-dsvm-neutron/c87b4fc/logs/screen-q-svc.txt.gz?level=TRACE

This is because on update, the dhcp agent only sends either this:

https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L770

or this:

https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L787

This is somewhat a corner case, but it would be good to address the issue to see what actually went wrong.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96226

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96226
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=82683feff64b5b0dff36f983526421e608f13d94
Submitter: Jenkins
Branch: master

commit 82683feff64b5b0dff36f983526421e608f13d94
Author: armando-migliaccio <email address hidden>
Date: Wed May 28 10:37:15 2014 -0700

    Fix KeyError exception while updating dhcp port

    This is caused by a missing network_id in the port body.
    This patch adds it so that a warning message can be traced
    correctly. Wording is slightly tweaked to ensure it applies
    to the right context.

    Closes-bug: #1324194

    Change-Id: I4b67b5c3584aa33278eb0e9e879ca338ba0ca8b0