Percentage spinners (e.g. zoom selector) should be localizable

Bug #1323601 reported by Adolfo Jayme Barrientos
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Pinta
Fix Released
Medium
Cameron White

Bug Description

Some languages (such as German, French, Slovenian and Spanish) should display the percent sign separated from the number by a space. (12 %)
Others (such as Turkish and Basque) display it before the number (%13 or % 14).
This is an issue that should be handled per locale in a more low-level library, but that’s an utopia.

Changed in pinta:
importance: Undecided → Medium
milestone: none → 1.6
status: New → Triaged
Revision history for this message
Cameron White (cameronwhite91) wrote :
Changed in pinta:
assignee: nobody → Cameron White (cameronwhite91)
status: Triaged → Fix Committed
Revision history for this message
grofaty (grofaty) wrote :
Revision history for this message
grofaty (grofaty) wrote :
Changed in pinta:
status: Fix Committed → New
Revision history for this message
grofaty (grofaty) wrote :

I don't think this is fixed. See above two attachments for detailed explanation. In short, for Slovenian there should be space between number and percentage character.

Revision history for this message
Cameron White (cameronwhite91) wrote :

The current implementation just uses the standard percent format specifier (https://msdn.microsoft.com/en-us/library/dwhawy9k%28v=vs.110%29.aspx#PFormatString). Since that doesn't seem to be correct for some locales, I think we'll need to add a translatable string so that the percent sign can be formatted correctly for each language.

Revision history for this message
Cameron White (cameronwhite91) wrote :

Fixed: https://github.com/PintaProject/Pinta/commit/7653dd178e134c761830b34b97e139e36f519238

There is now a translatable string for how to format the zoom percentage. Although I said we are in a string freeze, I think adding this one is ok since the untranslated version is no different than what we had in Pinta previously.

Changed in pinta:
status: New → Fix Committed
Changed in pinta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.