[enhancement] Draw input event location
Bug #1323522 reported by
Thomi Richards
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Wishlist
|
Robert Carr | ||
0.6 |
Won't Fix
|
Wishlist
|
Robert Carr | ||
mir (Ubuntu) |
Fix Released
|
Wishlist
|
Unassigned | ||
mir (Ubuntu RTM) |
Fix Released
|
Wishlist
|
Unassigned | ||
unity8 (Ubuntu) |
Opinion
|
Wishlist
|
Gerry Boland |
Bug Description
New feature request:
While running autopilot tests, it's impossible to tell where the autopilot-generated touch events are being generated. We'd like mir to draw a graphical overlay (a small blue circle perhaps) whever the touch events are being generated.
Our requirements are:
1) Must be toggleable from python.
1.1) ...Ideally wihtout having to restart unity8/mir - perhaps this could be a unity8 setting, with a way to set that from python?
2) Must draw a graphical overlay at the location of touch events generated from autopilot (to test, follow https:/
Please let me know if anything doesn't make sense.
Cheers
Related branches
lp:~mir-team/mir/touchspot-visualizer
- PS Jenkins bot (community): Approve (continuous-integration)
- Cemil Azizoglu (community): Approve
- Alan Griffiths: Approve
- Kevin DuBois: Pending requested
- Daniel van Vugt: Pending requested
-
Diff: 983 lines (+465/-48)26 files modifiedinclude/server/mir/default_server_configuration.h (+3/-0)
include/server/mir/input/android/default_android_input_configuration.h (+3/-0)
include/server/mir/input/touch_visualizer.h (+58/-0)
include/test/mir_test/event_factory.h (+12/-1)
include/test/mir_test/fake_event_hub_input_configuration.h (+2/-0)
include/test/mir_test_doubles/stub_touch_visualizer.h (+43/-0)
include/test/mir_test_framework/input_testing_server_configuration.h (+1/-1)
server-ABI-sha1sums (+3/-2)
src/server/input/android/android_input_reader_policy.cpp (+7/-2)
src/server/input/android/android_input_reader_policy.h (+4/-1)
src/server/input/android/android_pointer_controller.cpp (+27/-13)
src/server/input/android/android_pointer_controller.h (+15/-9)
src/server/input/android/default_android_input_configuration.cpp (+3/-1)
src/server/input/default_configuration.cpp (+18/-0)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_client_input.cpp (+2/-2)
tests/acceptance-tests/test_server_shutdown.cpp (+2/-1)
tests/acceptance-tests/test_touchspot_visualization.cpp (+222/-0)
tests/integration-tests/input/android/test_android_cursor_listener.cpp (+3/-0)
tests/integration-tests/input/android/test_android_input_manager.cpp (+5/-1)
tests/mir_test_doubles/event_factory.cpp (+13/-5)
tests/mir_test_doubles/fake_event_hub.cpp (+8/-5)
tests/mir_test_doubles/fake_event_hub_input_configuration.cpp (+2/-1)
tests/mir_test_framework/input_testing_server_options.cpp (+2/-1)
tests/unit-tests/input/android/test_android_input_reader_policy.cpp (+3/-1)
tests/unit-tests/input/android/test_android_pointer_controller.cpp (+3/-1)
lp:~mir-team/mir/touchspot-renderable
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel van Vugt: Needs Fixing
- Andreas Pokorny (community): Approve
- Alberto Aguirre (community): Approve
- Kevin DuBois (community): Approve
- Cemil Azizoglu (community): Approve
-
Diff: 3585 lines (+2202/-95)77 files modifieddebian/control (+2/-2)
debian/libmirplatform3.install (+1/-1)
include/platform/mir/graphics/platform.h (+3/-0)
include/platform/mir/options/configuration.h (+1/-0)
include/server/mir/default_server_configuration.h (+5/-2)
include/server/mir/input/cursor_listener.h (+2/-2)
include/server/mir/input/touch_visualizer.h (+6/-2)
platform-ABI-sha1sums (+2/-2)
playground/demo-shell/demo_compositor.cpp (+6/-1)
playground/demo-shell/demo_renderer.cpp (+8/-3)
playground/demo-shell/demo_renderer.h (+7/-1)
server-ABI-sha1sums (+5/-4)
src/include/platform/mir/graphics/buffer_writer.h (+44/-0)
src/include/platform/mir/graphics/native_platform.h (+3/-0)
src/include/server/mir/compositor/scene_element.h (+4/-0)
src/include/server/mir/input/scene.h (+23/-8)
src/include/server/mir/scene/legacy_scene_change_notification.h (+2/-0)
src/include/server/mir/scene/observer.h (+4/-0)
src/platform/CMakeLists.txt (+1/-1)
src/platform/graphics/android/CMakeLists.txt (+1/-0)
src/platform/graphics/android/android_buffer_writer.cpp (+70/-0)
src/platform/graphics/android/android_buffer_writer.h (+50/-0)
src/platform/graphics/android/android_display.cpp (+1/-1)
src/platform/graphics/android/android_platform.cpp (+6/-0)
src/platform/graphics/android/android_platform.h (+1/-0)
src/platform/graphics/mesa/CMakeLists.txt (+1/-0)
src/platform/graphics/mesa/buffer_allocator.cpp (+1/-1)
src/platform/graphics/mesa/buffer_writer.cpp (+40/-0)
src/platform/graphics/mesa/buffer_writer.h (+43/-0)
src/platform/graphics/mesa/native_platform.cpp (+5/-0)
src/platform/graphics/mesa/native_platform.h (+1/-0)
src/platform/graphics/mesa/platform.cpp (+6/-0)
src/platform/graphics/mesa/platform.h (+1/-0)
src/platform/graphics/mesa/shm_buffer.cpp (+13/-0)
src/platform/graphics/mesa/shm_buffer.h (+2/-0)
src/platform/options/default_configuration.cpp (+3/-1)
src/platform/symbols.map (+2/-1)
src/server/graphics/default_configuration.cpp (+10/-0)
src/server/graphics/nested/nested_platform.cpp (+5/-0)
src/server/graphics/nested/nested_platform.h (+1/-0)
src/server/input/CMakeLists.txt (+1/-0)
src/server/input/android/android_input_registrar.cpp (+4/-0)
src/server/input/android/android_input_registrar.h (+1/-0)
src/server/input/android/android_input_target_enumerator.cpp (+4/-4)
src/server/input/android/android_input_target_enumerator.h (+3/-3)
src/server/input/android/input_sender.cpp (+9/-5)
src/server/input/android/input_sender.h (+1/-0)
src/server/input/cursor_controller.cpp (+8/-3)
src/server/input/cursor_controller.h (+3/-3)
src/server/input/default_configuration.cpp (+16/-10)
src/server/input/touchspot_controller.cpp (+166/-0)
src/server/input/touchspot_controller.h (+77/-0)
src/server/input/touchspot_image.c (+1034/-0)
src/server/scene/basic_surface.cpp (+0/-1)
src/server/scene/default_configuration.cpp (+2/-2)
src/server/scene/legacy_scene_change_notification.cpp (+5/-0)
src/server/scene/surface_stack.cpp (+78/-0)
src/server/scene/surface_stack.h (+16/-3)
src/server/symbols.map (+4/-1)
tests/acceptance-tests/test_nested_mir.cpp (+6/-1)
tests/acceptance-tests/test_touchspot_visualization.cpp (+2/-0)
tests/include/mir_test_doubles/null_platform.h (+7/-2)
tests/include/mir_test_doubles/stub_input_scene.h (+16/-5)
tests/include/mir_test_doubles/stub_scene_element.h (+5/-0)
tests/include/mir_test_doubles/stub_touch_visualizer.h (+6/-0)
tests/integration-tests/input/android/test_android_cursor_listener.cpp (+1/-1)
tests/integration-tests/input/android/test_android_input_manager.cpp (+1/-1)
tests/integration-tests/input/test_nested_input.cpp (+1/-1)
tests/mir_test_framework/stubbed_server_configuration.cpp (+13/-0)
tests/unit-tests/frontend/test_session_mediator.cpp (+1/-0)
tests/unit-tests/graphics/mesa/test_shm_buffer.cpp (+1/-1)
tests/unit-tests/graphics/nested/test_nested_platform.cpp (+5/-0)
tests/unit-tests/input/CMakeLists.txt (+1/-0)
tests/unit-tests/input/android/test_android_input_target_enumerator.cpp (+5/-4)
tests/unit-tests/input/test_cursor_controller.cpp (+12/-11)
tests/unit-tests/input/test_touchspot_controller.cpp (+199/-0)
tests/unit-tests/scene/test_surface_stack.cpp (+96/-0)
Changed in mir: | |
assignee: | nobody → Robert Carr (robertcarr) |
Changed in unity8: | |
assignee: | nobody → Gerry Boland (gerboland) |
Changed in mir: | |
status: | Triaged → In Progress |
milestone: | none → 0.6.0 |
tags: | added: enhancement |
Changed in mir: | |
milestone: | 0.6.0 → 0.7.0 |
Changed in mir: | |
milestone: | 0.7.0 → 0.6.0 |
Changed in mir: | |
milestone: | 0.7.0 → 0.8.0 |
Changed in mir: | |
milestone: | 0.8.0 → 0.9.0 |
Changed in mir: | |
milestone: | 0.9.0 → 0.8.0 |
Changed in mir (Ubuntu): | |
importance: | Undecided → Wishlist |
status: | New → Triaged |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir (Ubuntu RTM): | |
importance: | Undecided → Wishlist |
status: | New → Triaged |
affects: | unity8 → unity8 (Ubuntu) |
To post a comment you must log in.
It would be done in the compositor. So we could do it in Mir but Unity8 does its own compositing and would require its own implementation.