use placeholder_text_color for welcome secondary text

[Danielle Foré]

Instead of using insensitive text, it makes more sense to use the same color as placeholder text

[Danielle Foré (danrabbit)]

This is the code used by Gtk.CellRendererText. I can't quite wrap my head around what is going on here:

      PangoColor color;
      GtkStyleContext *context;
      GdkRGBA fg = { 0.5, 0.5, 0.5 };

      context = gtk_widget_get_style_context (widget);
      gtk_style_context_lookup_color (context, "placeholder_text_color", &fg);

      color.red = CLAMP (fg.red * 65535. + 0.5, 0, 65535);
      color.green = CLAMP (fg.green * 65535. + 0.5, 0, 65535);
      color.blue = CLAMP (fg.blue * 65535. + 0.5, 0, 65535);

      add_attr (attr_list,
                pango_attr_foreground_new (color.red, color.green, color.blue));

[Danielle Foré (danrabbit)]

Okay, this is way above my head, but here's what I've discovered:

The end goal is to use subtitle_label.set_attributes (attr_list); where attr_list is a Pango.AttributeList that contains the RGB values for our Pango foreground color.

The problem is that Gtk.StyleContext.lookup_color returns double values and Pango wants uint16 values.

So there's this whole song and dance about getting the RGB values from style context and storing them in a Gdk.RGBA and converting those values to something pango can read and then creating the attr_list.

So yeah.

[Danielle Foré (danrabbit)]

So instead of being crazy, I just fixed it in egtk by styling GraniteWidgetsWelcome's children. I've proposed a branch that removes the insensitive garbage and that should fix it.