./redstack kick-start <image_type> does not returns error for invalid image types

Bug #1322612 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Trove Integration
Fix Committed
Medium
Sushil Kumar

Bug Description

./redstack kick-start <image_type> does not returns error for invalid image types

if we use the partial name of valid image types (for eg. red of redis) then command does not gives error.

Since https://github.com/openstack/trove-integration/blob/master/scripts/functions_qemu#L52 uses expr because of which the problem crops up.

So a different way instead of expr should be used.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove-integration (master)

Fix proposed to branch: master
Review: https://review.openstack.org/95154

Changed in trove-integration:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Changed in trove-integration:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove-integration (master)

Reviewed: https://review.openstack.org/95154
Committed: https://git.openstack.org/cgit/openstack/trove-integration/commit/?id=e3a7eb7556aa41446fc8ed579e9673bb6530fa6c
Submitter: Jenkins
Branch: master

commit e3a7eb7556aa41446fc8ed579e9673bb6530fa6c
Author: Sushil Kumar <email address hidden>
Date: Fri May 23 12:48:54 2014 +0000

    Corrects condition to check valid SERVICE_TYPE

    Reasons:
    - Currently expr is used to match condition, because of which the if
      part of valid SERVICE_TYPE is used, for eg. "mysq" of "mysql", then
      it is not called as invalid SERVICE_TYPE.

    Changes:
    - Updates the condition to match SERVICE_TYPE in VALID_SERVICES.

    Change-Id: Ia6b1d09d0cb3cf651e08f5c85573e7b32032d9fc
    Closes-Bug: #1322612

Changed in trove-integration:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.