maas-import-pxe-files fails when run from the command line
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Graham Binns |
Bug Description
Running maas-import-
graham@angua: maas$ bin/py scripts/
2014-05-23 13:39:52,892 ERROR Unhandled exception; unable to continue.
Traceback (most recent call last):
File "scripts/
main(args)
File "/home/
if args.config:
AttributeError: 'Namespace' object has no attribute 'config'
This is because the script is looking for a "config" blob in the arguments to main, but none exists. Nor is it specified that it *could* exist. This looks like a combination of tests not testing the script from end-to-end (nothing tests scripts/
The script doesn't actually need to accept the config blob anymore – that code is a vestigial thinko from the first work to remove bootresources.yaml. It's easiest to just remove that check for args.config and the associated tests.
Related branches
- Jeroen T. Vermeulen (community): Approve
-
Diff: 73 lines (+4/-29)2 files modifiedsrc/provisioningserver/import_images/boot_resources.py (+1/-10)
src/provisioningserver/import_images/tests/test_boot_resources.py (+3/-19)
Changed in maas: | |
status: | In Progress → Fix Committed |
milestone: | none → 1.6.0 |
Changed in maas: | |
status: | Fix Committed → Fix Released |