[EC2] Terminateinstance returns incorrect current state name

[Swami Reddy]

TerminateInstance returns the currentstate name and previousstate name are same.
In the below sample response elements show the currnentstate name and previoustate name as "running".
Ideally the currentstate name should be "terminated".
==
<TerminateInstancesResponse xmlns="http://ec2.amazonaws.com/doc/2013-10-15/">
  <requestId>req-c15f5c7d-2551-4a08-b8b8-255462a09592</requestId>
  <instancesSet>
    <item>
      <instanceId>i-00000001</instanceId>
      <currentState>
        <code>16</code>
        <name>running</name>
      </currentState>
      <previousState>
        <code>16</code>
        <name>running</name>
      </previousState>
    </item>
  </instancesSet>
</TerminateInstancesResponse>
==

[Tracy Jones (tjones-i)]

Swami - if you are working on this, please update. Otherwise you should remove your name

[Swami Reddy (swamireddy)]

 Will submit the patch soon.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104860

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104860
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e15ce7735e492f9eb0914efb621211e315ea40d9
Submitter: Jenkins
Branch: master

commit e15ce7735e492f9eb0914efb621211e315ea40d9
Author: Swami Reddy <email address hidden>
Date: Wed Aug 27 14:03:05 2014 +0530

    Fix the current state name as 'shutting-down'

    Currently, the TerminateInstance returns the currentstate name
    as previous state name. Ideally the TerminateInstance return
    element's currentstate named as "shutting-down".

    Addressed the issue and below is the terminateinstance response with fix:
    ==
    <TerminateInstancesResponse xmlns="http://ec2.amazonaws.com/doc/2013-10-15/">
      <requestId>req-c15f5c7d-2551-4a08-b8b8-255462a09592</requestId>
      <instancesSet>
        <item>
          <instanceId>i-00000001</instanceId>
          <currentState>
            <code>32</code>
            <name>shutting-down</name>
          </currentState>
          <previousState>
            <code>16</code>
            <name>running</name>
          </previousState>
        </item>
      </instancesSet>
    </TerminateInstancesResponse>
    ==

    And also updated the testcases in nova/tests/api/ec2/test_cloud.py
    appropriately.

    Closes-bug: #1322025

    Change-Id: I790e7d86ef8fd9f4fc1612bae2788e0ae7ef9719