Bug #1321886 “[regression] stale frame on seen on greeter when s...” : Bugs : Mir

kevin gunn (kgunn72) on 2014-05-21

Changed in mir:
importance:	Undecided → Critical
milestone:	none → 0.2.0
tags:	added: regression

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-22:

#1

Sounds like bug 1321861 actually... ?

Changed in mir:
status:	New → Incomplete

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-22:

#2

Actually, yes. It sounds just like bug 1321861 so marking as a duplicate for now.

Revision history for this message

Alberto Aguirre (albaguirre) wrote on 2014-05-22:

#3

Nope unrelated to 1321861

Changed in mir:
status:	Incomplete → Triaged

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-22:

#4

Revert r1647?

Revision history for this message

Alberto Aguirre (albaguirre) wrote on 2014-05-22:

#5

This is a combination of the 1Hz rate during display off and the unity8 lifecycle kicking in at 3s - only 2-3 frames which is not enough to draw the greeter.

We need a solution that roughly allows:

- At a display on/compositor start event - optionally allow clients to queue up the content they want - flushing any ready buffers
- Mir should flush out the driver queue possibly by drawing blank frames (though this could probably be done by unity-system-compositor)

Maybe a flush method in the compositor interface? Then server implementations like USC or unity-mir can make use of it and they can synchronize with their clients however they'd like...

Revision history for this message

kevin gunn (kgunn72) wrote on 2014-05-22:

#6

why wouldn't speeding up the render frequency to something closer to the display solve this (mostly) ?
also, keeping it at 1hz has the knock-on undesired system effect of laggy event servicing from the qt toolkit case.

Daniel van Vugt (vanvugt) on 2014-05-22

Changed in mir:
status:	Triaged → In Progress
assignee:	nobody → Daniel van Vugt (vanvugt)

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-22:

#7

We need to be careful to not rely on timing for anything. Timing is flimsy and lacks the robustness of logical guarantees we had previously depended on till now. I think we need to revisit that and reconsider how all these new problems can be solved without any time-measurement. There's always a way, it just requires more careful thought.

description:

updated

Daniel van Vugt (vanvugt) on 2014-05-22

summary:

- [regression] stale frame on seen on greeter when screen is unblanked
+ [regression] stale frame on seen on greeter when screen is unblanked and
+ toolkit/apps are laggy/throttled

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-22:

#8

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-06-06:

#9

Download full text (7.2 KiB)

This bug was fixed in the package mir - 0.2.0+14.10.20140605-0ubuntu1

---------------
mir (0.2.0+14.10.20140605-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.2.0 (https://launchpad.net/mir/+milestone/0.2.0)
    - mirclient ABI unchanged, still at 7. Clients do not need rebuilding.
    - mirserver ABI bumped to 20. Shells need rebuilding.
      . Cursor::set_image() parameters changed.
      . Display::the_cursor() renamed to Display::create_hardware_cursor()
      . Platform::create_display() requires a new parameter; gl_program_factory
      . Renderable::buffer() no longer accepts any parameter at all. Multi-
        monitor frame sync is guaranteed in other ways now.
      . Scene::generate_renderable_list() renamed to renderable_list_for(id)
        where id is an opaque compositor ID of your choosing.
      . Scene::set_change_callback() replaced by the more generic:
        add_observer() and remove_observer() functions.
      . Added default implementation for SceneObserver.
      . SessionCreator renamed to ConnectionCreator.
      . ConnectedSessions renamed to Connections.
      . ProtobufSessionCreator renamed to ProtobufConnectionCreator.
      . SessionAuthorizer: pid_t parameters replaced by SessionCredentials.
      . Massive architectural changes to Input-everything.
      . Surface no longer implements Renderable, but emits one via
        compositor_snapshot().
      . Pass the full renderable list to Renderer::render().
      . Graceful handling of exceptions thrown from server threads.
      . Clarify size position interfaces in the Surface classes.
      . Plumbing for trusted sessions.
      . Allow posting and managing custom main-loop actions.
      . Timer extension.
      . Identify client process when client connects to Mir not when socket
        connects.
      . Use the ServerActionQueue for display config.
      . Recomposition signal moved to the MultiThreadedCompositor.
      . Make timer service replaceable.
      . Clarify assumptions about how many buffers a client can fill without
        blocking.
      . Introduce EmergencyCleanup interface.
    - Demo shell enhancements:
      . You can now change graphics modes on the fly using Ctrl+Alt+(-/=).
        To reset to the preferred mode use Ctrl+Alt+0.
      . The above mode changing as well as existing screen rotation keys
        (Ctrl+Alt+arrows) are now per-display; only applied to the monitor
        the mouse pointer is on.
      . New shell controls documented.
    - A new testing category, performance test, was introduced. It currently
      runs glmark2-es2 and compares the result to a minimum threshold.
    - MIR_VERSION_MINOR is tied to MIRSERVER_ABI in the sense that a change
      in the former now requires dependent projects that a rebuild is
      necessary.
    - SwitchingBundle was replaced by BufferQueue.
    - Expand credentials to include uid/gid for session authorizer.
    - Bypass control is now Mesa-specific and tied to the command line options.
      So the environment variable MIR_BYPASS has changed to MIR_SERVER_BYPASS.
    - Ongoing architectural changes in the compositor/renderer logic to
   ...

This bug was fixed in the package mir - 0.2.0+14.10.20140605-0ubuntu1

---------------
mir (0.2.0+14.10.20140605-0ubuntu1) utopic; urgency=medium

[ Daniel van Vugt ]
  * New upstream release 0.2.0 (https://launchpad.net/mir/+milestone/0.2.0)
    - mirclient ABI unchanged, still at 7. Clients do not need rebuilding.
    - mirserver ABI bumped to 20. Shells need rebuilding.
      . Cursor::set_image() parameters changed.
      . Display::the_cursor() renamed to Display::create_hardware_cursor()
      . Platform::create_display() requires a new parameter; gl_program_factory
      . Renderable::buffer() no longer accepts any parameter at all. Multi-
        monitor frame sync is guaranteed in other ways now.
      . Scene::generate_renderable_list() renamed to renderable_list_for(id)
        where id is an opaque compositor ID of your choosing.
      . Scene::set_change_callback() replaced by the more generic:
        add_observer() and remove_observer() functions.
      . Added default implementation for SceneObserver.
      . SessionCreator renamed to ConnectionCreator.
      . ConnectedSessions renamed to Connections.
      . ProtobufSessionCreator renamed to ProtobufConnectionCreator.
      . SessionAuthorizer: pid_t parameters replaced by SessionCredentials.
      . Massive architectural changes to Input-everything.
      . Surface no longer implements Renderable, but emits one via
        compositor_snapshot().
      . Pass the full renderable list to Renderer::render().
      . Graceful handling of exceptions thrown from server threads.
      . Clarify size position interfaces in the Surface classes.
      . Plumbing for trusted sessions.
      . Allow posting and managing custom main-loop actions.
      . Timer extension.
      . Identify client process when client connects to Mir not when socket
        connects.
      . Use the ServerActionQueue for display config.
      . Recomposition signal moved to the MultiThreadedCompositor.
      . Make timer service replaceable.
      . Clarify assumptions about how many buffers a client can fill without
        blocking.
      . Introduce EmergencyCleanup interface.
    - Demo shell enhancements:
      . You can now change graphics modes on the fly using Ctrl+Alt+(-/=).
        To reset to the preferred mode use Ctrl+Alt+0.
      . The above mode changing as well as existing screen rotation keys
        (Ctrl+Alt+arrows) are now per-display; only applied to the monitor
        the mouse pointer is on.
      . New shell controls documented.
    - A new testing category, performance test, was introduced. It currently
      runs glmark2-es2 and compares the result to a minimum threshold.
    - MIR_VERSION_MINOR is tied to MIRSERVER_ABI in the sense that a change
      in the former now requires dependent projects that a rebuild is
      necessary.
    - SwitchingBundle was replaced by BufferQueue.
    - Expand credentials to include uid/gid for session authorizer.
    - Bypass control is now Mesa-specific and tied to the command line options.
      So the environment variable MIR_BYPASS has changed to MIR_SERVER_BYPASS.
    - Ongoing architectural changes in the compositor/renderer logic to
      prepare for overlay support, and to reduce locking overhead.
    - Made InputDispatcher replaceable.
    - Progress made on new cursor interfaces with the end goal of client and
      toolkit control of the mouse cursor appearance. More work required.
    - Updated cross-compile docs and scripts to support the latest utopic
      devel images.
    - Replaced uses of android::sp with std::shared_ptr.
    - Client cursor API infrastructure.
    - Enabled eglSwapInternal(0).
    - Make texture caching algorithm reuseable.
    - Add a DPI surface attribute.
    - Exclude arm64 from build.
    - Bugs fixed:
      . Mir doesn't install cleanly if docs are not built. (LP: #1304271)
      . Unity-system-compositor crashed [what(): Failed to set DRM crtc].
        (LP: #1294510)
      . [regression] unity8 fails to load libmirplatformgraphics
        (undefined symbol: _ZN3mir8graphics9GLProgramD1Ev). (LP: #1317200)
      . [regression] unity8 rendering artifacts. (LP: #1317260)
      . [regression] [BufferQueue]
        BufferQueueTest.compositor_never_owns_client_buffers occasionally
        crashes with: what(): unexpected release: buffer was not given to
        compositor. (LP: #1317801)
      . Hardcoded size for serialization buffers is neither reliable nor
        secure. (LP: #1320187)
      . [regression] [BufferQueue] mir does not composite last client given
        buffer. (LP: #1321861)
      . [regression] stale frame on seen on greeter when screen is unblanked
        and toolkit/apps are laggy/throttled. (LP: #1321886)
      . [regression] [BufferQueue] current_buffer_users vector memory usage
        grows unbounded. (LP: #1317808)
      . Intermittent test failures in
        CustomInputDispatcherFixture.custom_input_dispatcher_receives_input.
        (LP: #1318587)
      . [regression] [BufferQueue] Race condition in
        BufferQueue::compositor_acquire could underflow shared_ptr refcount and
        delete prematurely, crash. (LP: #1318632)
      . Overflow in
        mir::client::rpc::MirSocketRpcChannel::receive_file_descriptors as
        reported by address sanitizer. (LP: #1320821)
      . [regression] [input] Scroll events are now always zero:
        event.motion.pointer_coordinates[0].vscroll. (LP: #1321077)
      . CI failures in CustomInputDispatcherFixture
        .custom_input_dispatcher_gets_started_and_stopped. (LP: #1321215)
      . [regression] Mir cursor vanishes after switching VTs. (LP: #1323225)
      . Server library links against libmirserverlttng. (LP: #1323317)
      . [DRM/GBM] Killing (or crashing) Mir often leaves the screen blank and
        difficult to recover. (LP: #1189770)
      . Frame rates of GL clients are limited to 60Hz on Android, even with
        swapinterval=0. (LP: #1206400)
      . mir_surface_is_valid(NULL) crashes instead of returning false.
        (LP: #1248474)
      . [regression] tests/unit-tests/shell/test_mediating_display_changer.cpp
        is not compiled and executed. (LP: #1312832)
      . Android platform does not reset the compositionType to HWC_FRAMEBUFFER
        before prepare() on every frame. (LP: #1314399)
      . The client process is identified when the socket connects, not when the
        client connects to Mir. (LP: #1314574)
      . [regression] Clients can't acquire multiple buffers any more.
        (LP: #1315302)
      . [regression] Enabling SwitchingBundleTest
        DISABLED_synchronous_clients_only_get_two_real_buffers now crashes with
        no usable stack trace. It used to only fail. (LP: #1315312)
      . [regression] [BufferQueue] double-buffered client freezes as no buffer
        is returned on compositor_release. (LP: #1319765)
      . Uninitialized mem in OutputBuilder.hwc_version_11_success.
        (LP: #1312867)
      . [enhancement] In the tests make it possible to get a
        DefaultConfiguration initialized from the command line (LP: #1316987)
      . ci train blocked due to missing arm64 libandroid-properties-dev.
        (LP: #1323504)
  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <ps-jenkins@lists.canonical.com>   Thu, 05 Jun 2014 14:02:57 +0000

Changed in mir (Ubuntu):
status:	New → Fix Released

Daniel van Vugt (vanvugt) on 2014-07-01

Changed in mir:
status:	Fix Committed → Fix Released

Mir

[regression] stale frame on seen on greeter when screen is unblanked and toolkit/apps are laggy/throttled

Bug Description

Related branches

Other bug subscribers

Remote bug watches

Affects		Status	Importance	Assigned to	Milestone
	Mir	Fix Released	Critical	Daniel van Vugt	Mir 0.2.0
	mir (Ubuntu)	Fix Released	Undecided	Unassigned