[regression] stale frame on seen on greeter when screen is unblanked and toolkit/apps are laggy/throttled
Bug #1321886 reported by
kevin gunn
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Critical
|
Daniel van Vugt | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
With the landing of https:/
we now have the return of the bug which a "stale" frame of application render is seen on top of greeter
with the 1Hz policy, upon screen blank, lifecycle kicks in at around 3s
so there's only around 3 frames drawn.
also volume key is laggy. b/c the toolkit interrupt service slows down to the same rate as well.
Related branches
lp:~vanvugt/mir/revert-r1647
- Alan Griffiths: Approve
- Daniel van Vugt: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 3043 lines (+378/-1552)38 files modifiedinclude/platform/mir/graphics/buffer_id.h (+1/-1)
include/server/mir/asio_main_loop.h (+0/-2)
include/server/mir/compositor/frame_dropping_policy.h (+0/-69)
include/server/mir/compositor/frame_dropping_policy_factory.h (+0/-57)
include/server/mir/default_server_configuration.h (+0/-3)
include/server/mir/time/timer.h (+1/-8)
include/test/mir_test/fake_clock.h (+0/-72)
include/test/mir_test/signal.h (+0/-63)
include/test/mir_test_doubles/mock_frame_dropping_policy_factory.h (+0/-83)
include/test/mir_test_doubles/mock_timer.h (+0/-52)
include/test/mir_test_doubles/stub_frame_dropping_policy_factory.h (+0/-58)
src/server/asio_main_loop.cpp (+9/-23)
src/server/compositor/CMakeLists.txt (+0/-1)
src/server/compositor/buffer_queue.cpp (+1/-37)
src/server/compositor/buffer_queue.h (+1/-5)
src/server/compositor/buffer_stream_factory.cpp (+4/-6)
src/server/compositor/buffer_stream_factory.h (+4/-4)
src/server/compositor/default_configuration.cpp (+1/-15)
src/server/compositor/multi_threaded_compositor.cpp (+135/-53)
src/server/compositor/timeout_frame_dropping_policy_factory.cpp (+0/-92)
src/server/compositor/timeout_frame_dropping_policy_factory.h (+0/-56)
tests/acceptance-tests/test_client_surface_swap_buffers.cpp (+13/-8)
tests/integration-tests/compositor/test_buffer_stream.cpp (+15/-45)
tests/integration-tests/compositor/test_swapping_swappers.cpp (+1/-3)
tests/integration-tests/graphics/android/test_buffer_integration.cpp (+1/-4)
tests/integration-tests/graphics/android/test_internal_client.cpp (+1/-2)
tests/mir_test/CMakeLists.txt (+0/-2)
tests/mir_test/fake_clock.cpp (+0/-53)
tests/mir_test/signal.cpp (+0/-46)
tests/mir_test_doubles/CMakeLists.txt (+0/-2)
tests/mir_test_doubles/mock_frame_dropping_policy_factory.cpp (+0/-70)
tests/mir_test_doubles/mock_timer.cpp (+0/-149)
tests/unit-tests/compositor/CMakeLists.txt (+0/-1)
tests/unit-tests/compositor/test_buffer_queue.cpp (+46/-128)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+78/-15)
tests/unit-tests/compositor/test_timeout_frame_dropping_policy.cpp (+0/-186)
tests/unit-tests/graphics/mesa/test_linux_virtual_terminal.cpp (+0/-1)
tests/unit-tests/test_asio_main_loop.cpp (+66/-77)
Changed in mir: | |
importance: | Undecided → Critical |
milestone: | none → 0.2.0 |
tags: | added: regression |
Changed in mir: | |
status: | Triaged → In Progress |
assignee: | nobody → Daniel van Vugt (vanvugt) |
summary: |
- [regression] stale frame on seen on greeter when screen is unblanked + [regression] stale frame on seen on greeter when screen is unblanked and + toolkit/apps are laggy/throttled |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Sounds like bug 1321861 actually... ?