Project panels (like Networks panel) can't be actually disabled

[Pavel A.]

I'm trying to disable the Networks panel for project dashboard. Putting like:
PANEL = 'networks'
PANEL_DASHBOARD = 'project'
PANEL_GROUP = 'network'
REMOVE_PANEL = True

to local/enabled works perfect but after that the networks panel under Admin panel group got broken.

Django Version: 1.4.5
Exception Type: TemplateSyntaxError
Exception Value:

project/networks/_network_ips.html

Exception Location: /usr/lib/python2.7/dist-packages/django/template/loader.py in find_template, line 138
Python Executable: /usr/bin/python

Though, the same works with images panel in spite there are also references to project like :

from openstack_dashboard.dashboards.project.images.images import views

[Akihiro Motoki (amotoki)]

The bug occurs because admin network tables use a template from project dashboard but the template in the project network panel is not properly configured due to disabling the networking panel. [1][2] The easiest way to fix it seems to redefine get_subnet in admin/networks/tables.py.

We have the similar situation in get_ips and get_size in admin/instances/tables.py.

[1] http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/admin/networks/tables.py#n86
[2] http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/networks/tables.py#n109

[Pavel A. (vpaul)]

yes, the bug occurs because of admin dashboard uses some parts from project including network tables.

In my case I've managed with permissions trick like:

projects_dashboard = horizon.get_dashboard("project")
networks_panel = projects_dashboard.get_panel("networks")

permissions = list(getattr(networks_panel, 'permissions', []))
permissions.append('openstack.roles.admin')
networks_panel.permissions = tuple(permissions)

Though, it should be revised I suppose.

[Akihiro Motoki (amotoki)]

It seems complicated than I expected.

Many admin panel depends on corresponding project panel.
In addition to the report bug, instance detail and network detail pages also cannot be rendered due to the same reason
when project instance panel and project network panel are disabled.
All are because required templates exist in project panel.

It seems we need a way to use templates in project panel from admin panel even when project panel is disabled.
Some requirement declaration may be needed.

Another *adhoc* way seems to copy all required templates from project/ to admin/.

I don't have time to investigate it more deeply right now.
I remove me from the assignee.

[Akihiro Motoki (amotoki)]

IMHO the ideal way is to have a location which stores common templates
so that every panel can use templates as it wants even though some panel
is disabled. At the moment I don't have a good idea where is the best place.
It is just an idea.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408583

[anusha (anusha)]

1.Disabling networks panel in Project,admin networks panel should work.
2.Maintained common templates used by both Project and Admin separately in the path
    horizon/openstack_dashboard/templates/networks/

Change-Id: If1750c35a63fe546436e1abe31f14ddc56c0fd1c
Closes-Bug: #1321865

https://review.openstack.org/#/c/408583/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/427114

[OpenStack Infra (hudson-openstack)]

Change abandoned by anusha (<email address hidden>) on branch: master
Review: https://review.openstack.org/408583

[Akihiro Motoki (amotoki)]

There seems two possible approaches.
(a) Move templates used in both the admin and project panels into some common place like openstack_dashboard/static/xxx. This solution might require us to move files a bit often.
(b) Declare dependencies on other templates and if declared the plugin framework add it to the template path. If the dependency is only from admin to project, this solution works.

[Akihiro Motoki (amotoki)]

This is not specific to the network panel. The title should be updated.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/427114
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.