Linaro

linux-3.15-rc5/arch/arm/mach-orion5x/ts78xx-setup.c:609: possible missing sanity check ?

Bug #1321856 reported by dcb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro
New
Undecided
Unassigned

Bug Description

[linux-3.15-rc5/arch/arm/mach-orion5x/ts78xx-setup.c:609] -> [linux-3.15-rc5/arch/arm/mach-orion5x/t
s78xx-setup.c:610]: (performance) Variable 'ret' is reassigned a value before the old one has been u
sed.

    ret = ts78xx_fpga_load();
    ret = sysfs_create_file(firmware_kobj, &ts78xx_fpga_attr.attr);

Suggest sanity check first assignment to ret.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.