Program crashes when deleting more than one user script
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Midori Web Browser |
Fix Released
|
High
|
Unassigned |
Bug Description
When using the User Addons extension, the program crashes when deleting more than one user script.
Steps to reproduce:
Launch Midori
Enable User Addons extension
Open Userscripts panel
Install a few scripts
Restart Midori
Open Userscripts panel
Remove more than one script
Upon removal of the second (or more) script, the program crashes.
Command line C:\Program Files (x86)\Midori\
Midori 0.5.7 (de.twotoasts.
GTK+ 3.6.4 (3.6.4) Glib 2.34.3 (2.34.3)
WebKitGTK+ 1.10.2 (1.10.2) libSoup 2.40.3
cairo 1.12.10 (1.12.10) libnotify No
gcr No granite No
Platform Windows NT 6.2
Identification Mozilla/5.0 (Windows NT 6.2) AppleWebKit/537.6 (KHTML, like Gecko) Chrome/
Video Formats H264 [x] Ogg Theora [x] WebM [x]
Other extensions being used:
Adobe Acrobat
Advertisement blocker
Cookie Manager
Cookie Security Manager
Toolbar Editor
Related branches
- Paweł Forysiuk: Approve
- Cris Dywan: Approve (needs-testing)
-
Diff: 66 lines (+22/-2)1 file modifiedextensions/addons.c (+22/-2)
tags: | added: crash |
Changed in midori: | |
status: | Confirmed → Fix Committed |
Changed in midori: | |
milestone: | none → 0.6.0 |
Changed in midori: | |
status: | Fix Committed → Fix Released |
Changed in midori: | |
milestone: | 0.6.0 → 0.5.10 |
It looks like addons is sloppy in keeping track of references to rows in its treeview, which is repopulated when it notices the filesystem changes (it notices this at most once per second). Thus, if you delete a script and then delete another without waiting a couple seconds in between, the second "delete?" dialog is interrupted by the filesystem change being noticed and loses its reference to the selected row.