[client] python33 unit test failures

Bug #1321430 reported by Steve McLellan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Sergey Murashov

Bug Description

The python33 unit tests fail for muranoclient because they use unittest2 which was specifically to backport features to python 2.x and doesn't work with python 3 (in this case because it's using the old exception handling syntax `except Exception, e`). It doesn't appear that the tests use any features from unittest2.

While I don't think we necessarily need to run on python 3, we should tidy up these tests (there are also various places using `assert condition==something` rather than self.assertEquals(condition, something) so that they're more pythonic. It is better to do this sooner than later so that they can be a useful example for more unit tests.

Changed in murano:
importance: Undecided → Medium
assignee: nobody → Sergey Murashov (smurashov)
status: New → Confirmed
Changed in murano:
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-muranoclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/95453

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/95453
Committed: https://git.openstack.org/cgit/stackforge/python-muranoclient/commit/?id=f39e9ccac2a189eb92a43e8912517a15f0aad774
Submitter: Jenkins
Branch: master

commit f39e9ccac2a189eb92a43e8912517a15f0aad774
Author: Sergey Murashov <email address hidden>
Date: Mon May 26 12:08:27 2014 +0400

    Fix issue with python 3.3 gate job

    Change-Id: Iec40988c71bd5743d8ea90f225ac49b470171952
    Closes-Bug: #1321430

Changed in murano:
status: In Progress → Fix Committed
ruhe (ruhe)
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.