Deadlocks in tests in stop deployment task

Bug #1321302 reported by Alexander Kislitsky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Alexander Kislitsky

Bug Description

Deadlocks appears in tests in rpc receiver in stop_deployment task.
To fix we should use DB queries with lock (with_lockmode('update')).
Also in stop_deployment method we should use nailgun objects instead database models.

Changed in fuel:
importance: Undecided → High
milestone: none → 5.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/94372

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/94372
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=7bf1a6296d442032f12d5d7d6c9c053f5800f56e
Submitter: Jenkins
Branch: master

commit 7bf1a6296d442032f12d5d7d6c9c053f5800f56e
Author: Alexander Kislitsky <email address hidden>
Date: Tue May 20 17:53:22 2014 +0400

    Fix for deadlocks in stop_deployment task

    Nailgun base object:
    - order_by method added into NailgunCollection
    - get_by_id_lists renamed to filter_by_id_list
    - filtering by param logic extracted to method
    - filter_by_name method added

    Nailgun Node object:
    - move_roles_to_pending_roles method added

    Rpc receiver:
    - stop_deployment task refactored to nailgun objects
    - queries with locking and ordering used in stop_deployment
    - ordering added into locking queries in deploy_resp
    - fetched from db nodes used in deploy_resp

    Change-Id: Idff49dd7e01a159f4d5c4f4208aadf1894346b8e
    Closes-Bug: #1321302

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.