improve translations of logging messages

Bug #1321283 reported by Christian Berendt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Low
Christian Berendt

Bug Description

  * non debug messages should be translated
  * there should be checks in hacking

Changed in heat:
assignee: nobody → Christian Berendt (berendt)
status: New → In Progress
Changed in heat:
assignee: Christian Berendt (berendt) → Sergey Kraynev (skraynev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/94356
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ecd8d3999d7cc5680459433b34d6011a3f3ba0d2
Submitter: Jenkins
Branch: master

commit ecd8d3999d7cc5680459433b34d6011a3f3ba0d2
Author: Sergey Kraynev <email address hidden>
Date: Tue May 20 08:43:24 2014 -0400

    Replacing variable logger on LOG

    Commit https://review.openstack.org/#/c/94255/1 introduces check for
    translating log messages. This check uses in pattern name 'LOG', so in
    heat code also should be used this name intead of 'logger'. Also same
    name is used in other projects.

    Change-Id: Iba24c7eb1c13e68a91d090d7bcdbcb40d6e16071
    Partial-Bug: #1321283

Changed in heat:
assignee: Sergey Kraynev (skraynev) → Christian Berendt (berendt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/94217
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=105a8064930be75c8ab6ad3a8ef6f86d2eb9e1ba
Submitter: Jenkins
Branch: master

commit 105a8064930be75c8ab6ad3a8ef6f86d2eb9e1ba
Author: Christian Berendt <email address hidden>
Date: Mon May 19 18:10:55 2014 +0200

    all non debug log messages should be translated

    Updated a set of files to add missing translation support in the
    log messages.

    Change-Id: I58d561c5e1ecff550483ee0be696999e927c98ad
    Partial-Bug: #1321283

Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

See https://wiki.openstack.org/wiki/LoggingStandards#Guidelines for the way how to do this - patch 94217 does it the wrong way.

Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Low
Angus Salkeld (asalkeld)
Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.