[EC2] StartInstance response missing instanceset info

[Swami Reddy]

Startinstance response elements shown as below:

"<StartInstancesResponse xmlns=""http://ec2.amazonaws.com/doc/2013-10-15/"">
  <requestId>req-5970ccd7-c763-456c-89f0-5b55ea18880b</requestId>
  <return>true</return>
</StartInstancesResponse>
"

But as per the AWS API reference doc, the response elements shown be as below:
==
<StartInstancesResponse xmlns="http://ec2.amazonaws.com/doc/2014-02-01/">
  <requestId>59dbff89-35bd-4eac-99ed-be587EXAMPLE</requestId>
  <instancesSet>
    <item>
      <instanceId>i-10a64379</instanceId>
      <currentState>
          <code>0</code>
          <name>pending</name>
      </currentState>
      <previousState>
          <code>80</code>
          <name>stopped</name>
      </previousState>
    </item>
  </instancesSet>
</StartInstancesResponse>
===

here, <instanceSet> information missing in the response elements.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/95799

[Jay Pipes (jaypipes)]

Verified that the Amazon API WSDL for both the 2013-10-15 version (which OpenStack EC2 endpoint advertises) and 2014-02-01 version (from bug post) use the instancesSet XML element

[Swami Reddy (swamireddy)]

Jay - Thanks for review.
Yep, the fix include the <instanceSet> XML elements with <instanceID>, <currentState> and <previousState> Items.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/100438

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/100847

[OpenStack Infra (hudson-openstack)]

Change abandoned by Swami Reddy (<email address hidden>) on branch: master
Review: https://review.openstack.org/100847

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100438
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=37520a7dc14971b2d244f37febdb9fb13edbfd2f
Submitter: Jenkins
Branch: master

commit 37520a7dc14971b2d244f37febdb9fb13edbfd2f
Author: Swami Reddy <email address hidden>
Date: Wed Jun 18 15:49:18 2014 +0530

    Add instanceset info to StartInstance response

    Currently startinstance response doesn't have the
    instanceset information with InstanceID, current state
    and previous state. It just returns the "True".
    As per the AWS API reference document, the StartInstance
    response elements should include the instanceset information
    as below:
    <StartInstancesResponse xmlns="http://ec2.amazonaws.com/doc/2014-02-01/">
      <requestId>req-a7326465-5ce2-4ed6-ab89-394b38cca85f</requestId>
      <instancesSet>
        <item>
          <instanceId>i-00000001</instanceId>
          <currentState>
            <code>16</code>
            <name>running</name>
          </currentState>
          <previousState>
            <code>80</code>
            <name>stopped</name>
          </previousState>
        </item>
      </instancesSet>
    </StartInstancesResponse>

    Included the instanceset in to startinstance response elements
    and updated the test cases for startinstance response elements
    in nova/tests/api/ec2/test_cloud.py file.

    Change-Id: I08ef7ed88f983b66a30c76d6b7b754222097a03b
    Closes-bug: #1321220