[saas-3/trunk] auth_ldap: internal server error when logging with a wrong login/password

[Muschang Anthony (Acsone)]

With the module "auth_ldap" an internal server error message is displayed when the user uses a wrong login or password.

Scenario:
With the module "auth_ldap" installed
1/With admin, configure ldap for the admin company. The values in the configuration has no impact on the bug.
2/Logout as admin
3/Try to login as admin with a bad password
4/Internal Server Error, the browser cache/cookies must be cleaned in order to be able to log again.

Here is the stack trace in the server log:
File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/http.py", line 1128, in dispatch
     result = ir_http._dispatch()
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/addons/base/ir/ir_http.py", line 119, in _dispatch
    return self._handle_exception(e)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/addons/base/ir/ir_http.py", line 89, in _handle_exception
     return request._handle_exception(exception)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/addons/base/ir/ir_http.py", line 115, in _dispatch
    result = request.dispatch()
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/http.py", line 469, in dispatch
     r = self._call_function(**self.params)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/http.py", line 234, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/service/model.py", line 114, in wrapper
     return f(dbname, *args, **kwargs)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/http.py", line 231, in checked_call
    return self.func(*a, **kw)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/http.py", line 550, in call
     return self.method(*args, **kw)
  File "/home/openerp-pe/openerp4pe/addons-ep/comansys_homepage/main.py", line 11, in web_login
    response = super(LoginWithoutDatabaseLinks, self).web_login(*args, **kw)
   File "/home/openerp-pe/openerp4pe/addons-web/addons/web/controllers/main.py", line 677, in web_login
    uid = request.session.authenticate(request.session.db, request.params['login'], request.params['password'])
   File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/http.py", line 682, in authenticate
    uid = openerp.netsvc.dispatch_rpc('common', 'authenticate', [db, login, password, env])
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/netsvc.py", line 240, in dispatch_rpc
     result = dispatch(method, params)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/service/common.py", line 31, in dispatch
    return fn(*params)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/service/common.py", line 43, in exp_authenticate
     return res_users.authenticate(db, login, password, user_agent_env)
  File "/home/openerp-pe/openerp4pe/parts/openerp/openerp/addons/base/res/res_users.py", line 457, in authenticate
    uid = self.login(db, login, password)
   File "/home/openerp-pe/openerp4pe/addons/auth_ldap/users_ldap.py", line 254, in login
    entry = ldap_obj.authenticate(conf, login, password)
  File "/home/openerp-pe/openerp4pe/addons/auth_ldap/users_ldap.py", line 99, in authenticate
     filter = filter_format(conf['ldap_filter'], (login,))
  File "/home/openerp-pe/openerp4pe/eggs/python_ldap-2.4.9-py2.7-linux-x86_64.egg/ldap/filter.py", line 55, in filter_format
    return filter_template % (tuple(map(escape_filter_chars,assertion_values)))
 TypeError: not all arguments converted during string formatting

Tested with both Chrome and IE9.

[Muschang Anthony (Acsone) (anthony-muschang)]

Linked to opw-608126.