[regression] [input] Scroll events are now always zero: event.motion.pointer_coordinates[0].vscroll
Bug #1321077 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Andreas Pokorny | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[regression] [input] Scroll events are now always zero: event.motion.
Merging changes that landed on development-branch last night I notice vscroll is now always zero when action=
Test case:
1. Start: mir_demo_
2. Start a client
3. Alt+mousewheel up/down
Expected: Window opacity changes
Observed: No change to window opacity
Related branches
lp:~andreas-pokorny/mir/fix-1321077
- PS Jenkins bot (community): Approve (continuous-integration)
- Alexandros Frantzis (community): Approve
- Alan Griffiths: Approve
- Daniel van Vugt: Approve
-
Diff: 206 lines (+166/-1)2 files modifiedsrc/server/input/android/android_input_dispatcher.cpp (+3/-1)
tests/unit-tests/input/android/test_android_input_dispatcher.cpp (+163/-0)
Changed in mir: | |
status: | Triaged → In Progress |
description: | updated |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm not quite sure how, but it looks like the regression probably came from:
------- ------- ------- ------- ------- ------- ------- ------- ---- Configuration and the by-pass of the InputTranslator using a dynamic cast that was only necessary until lp~andreas- pokorny: extended- input-dispatche r lands
revno: 1639 [merge]
author: Andreas Pokorny <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Mon 2014-05-19 22:10:04 +0000
message:
Removing InputDispatcher
The contents of the former InputDispatcher Configuration have been moved to DefaultServerCo nfiguration. En passent the nested input relay was dropped too. The mir::input: :InputDispatche r interface is now used directly. Note: Event filtering still works like before.
Approved by PS Jenkins bot, Alexandros Frantzis, Alan Griffiths, Chris Halse Rogers. ------- ------- ------- ------- ------- ------- ------- ----
-------