Non-existent assertion methods being called on mocks

Bug #1320774 reported by Kevin Benton
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Kevin Benton

Bug Description

There are various places in the unit tests where non-existent "assert" methods are called on mock objects.

e.g. assert_called_once(), assert_called_twice(), assert_called_one_with(), assert_called_twice()

To reproduce, put the mock.py file in the base neutron directory and edit the __getattr__ methods to check if the name begins with 'assert' and raise an exception if true.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/94141

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/94141
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0ff8536c0d9b95172c42b1a01d292df58ed2e573
Submitter: Jenkins
Branch: master

commit 0ff8536c0d9b95172c42b1a01d292df58ed2e573
Author: Kevin Benton <email address hidden>
Date: Mon May 19 06:58:58 2014 +0000

    Fix non-existent 'assert' calls to mocks

    Fixes calls to non-existent 'assert' methods
    called on mock objects.

    Closes-Bug: #1320774
    Change-Id: I7eab28fc9b23cbb39d5507ff3e8004a493c90bed

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.