NotImplementedError of record_events will break notification-to-sample with mongodb backend

[Liusheng]

If we have configured "store_events" option as "True" and the environment use mongodb as storage backend.
it will raise NotImplementedError, because the implementation of mongodb storage haven't realize the record_events() method.

creating floatingip as examp:

ing event "floatingip.create.end" process_notification /opt/stack/ceilometer/ceilometer/event/endpoint.py:64
[-] Exception during message handling
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/notify/dispatcher.py", line 85, in _dispatch_and_handle_error
    return self._dispatch(incoming.ctxt, incoming.message)
  File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/notify/dispatcher.py", line 121, in _dispatch
    metadata)
  File "/opt/stack/ceilometer/ceilometer/event/endpoint.py", line 58, in info
    self.process_notification(notification)
  File "/opt/stack/ceilometer/ceilometer/event/endpoint.py", line 67, in process_notification
    problem_events.extend(dispatcher_ext.obj.record_events(event))
  File "/opt/stack/ceilometer/ceilometer/dispatcher/database.py", line 80, in record_events
    return self.storage_conn.record_events(events)
  File "/opt/stack/ceilometer/ceilometer/storage/base.py", line 315, in record_events
    raise NotImplementedError('Events not implemented.')
NotImplementedError: Events not implemented.

after that, use "ceilometer sample-list -m ip.floating", we can't get the sample from notification about floatingip.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/97669

[Lianhao Lu (lianhao-lu)]

Forgive my ignorance on oslo.messaging about notification listener. From what I read from the code, it seems that recording the event and storing the samples from the notificaitons are done in different notification endpoints. Why one notification endpoint(eventsNotificationEndpoint)'s failure would affect other endpoints' behavior? Is it the oslo.messaging.notification_listener designed?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97669
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=48e30f52d46ce61ca561c271d4c32700a8d27081
Submitter: Jenkins
Branch: master

commit 48e30f52d46ce61ca561c271d4c32700a8d27081
Author: liu-sheng <email address hidden>
Date: Tue Jun 3 17:43:54 2014 +0800

    Fix notification for NotImplemented record_events

    With mongodb as storage backend, notification-to-sample will be broken by
    NotImplementedError of record_events() method if we have set
    "store_events" option as True in ceilometer.conf.

    This patch catch the NotImplementedError and enable the
    notification-to-sample process.

    Change-Id: I7ace5a8581518fa56e58abca2e377b513ff38675
    Closes-Bug: #1320420