Get workbook definition if workbook doesn't exist returns 500 code

Bug #1320136 reported by Nikolay Makhotkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Nikolay Makhotkin

Bug Description

Steps to reproduce:

1. Run client
2. type "workbook-get-definition some-workbook-name"
3. See Server Error, while 404 expected

Changed in mistral:
importance: Undecided → High
assignee: nobody → Nikolay Makhotkin (nmakhotkin)
milestone: none → 0.1
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/93886

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/95626
Committed: https://git.openstack.org/cgit/stackforge/mistral/commit/?id=5e9ffd5c479260367b4be5d9d26f147a85c010a8
Submitter: Jenkins
Branch: master

commit 5e9ffd5c479260367b4be5d9d26f147a85c010a8
Author: Angus Salkeld <email address hidden>
Date: Tue May 27 16:23:00 2014 +1000

    Cleanup exceptions and add http code

    - Remove redundant constructors
    - always use "code" as an http_status
    - fix the default message strings so you can pass nothing into the
      exception constructor and it will work.
    - add some basic tests

    Partial-bug: #1320136
    Co-Authored-By: Nikolay Mahotkin <email address hidden>

    Change-Id: I9e21c6d5d39f1203324a37a39e5fd6069062b733

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/93886
Committed: https://git.openstack.org/cgit/stackforge/mistral/commit/?id=1ceb4b1e8ac2c49f1f458c804f5c1f8269b829a7
Submitter: Jenkins
Branch: master

commit 1ceb4b1e8ac2c49f1f458c804f5c1f8269b829a7
Author: Angus Salkeld <email address hidden>
Date: Wed May 28 12:38:40 2014 +1000

    Add/Fix all error handling mechanism on REST API

     * Refactor error handling
     * add tests for correct error codes

    Closes bug: #1320136
    Co-Authored-By: Angus Salkeld <email address hidden>
    Change-Id: Ia33e19cab4879164acb7c8268c9c657f4196df45

Changed in mistral:
status: In Progress → Fix Committed
no longer affects: mistral/juno
Changed in mistral:
milestone: 0.1 → 0.0.4
Changed in mistral:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.