impitool debug logging does not include node identifier

Bug #1319637 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Ellen Hui

Bug Description

e.g.

2014-05-15 05:00:30.927 30879 DEBUG ironic.common.utils [-] Execution completed, command line is "ipmitool -I lanplus -H A.B.C.D -L ADMINISTRATOR -U Administrator -f /tmp/tmpubOng6 power status" execute /opt/stack/venvs/ironic/local/lib/python2.7/site-packages/ironic/common/utils.py:65
2014-05-15 05:00:30.927 30879 DEBUG ironic.common.utils [-] Command stdout is: "Chassis Power is on
" execute /opt/stack/venvs/ironic/local/lib/python2.7/site-packages/ironic/common/utils.py:66
2014-05-15 05:00:30.928 30879 DEBUG ironic.common.utils [-] Command stderr is: "" execute /opt/stack/venvs/ironic/local/lib/python2.7/site-packages/ironic/common/utils.py:67
2014-05-15 05:00:30.928 30879 DEBUG ironic.drivers.modules.ipmitool [-] ipmitool stdout: 'Chassis Power is on
', stderr: '' _exec_ipmitool /opt/stack/venvs/ironic/local/lib/python2.7/site-packages/ironic/drivers/modules/ipmitool.py:152

Revision history for this message
Dmitry Tantsur (divius) wrote :

yeah, _exec_ipmitool and some other functions lack node ID

Changed in ironic:
status: New → Triaged
importance: Undecided → Low
tags: added: low-hanging-fruit
Ellen Hui (ellen-hui)
Changed in ironic:
assignee: nobody → Ellen Hui (ellen-hui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98928

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/98928
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=f3a62d5ca304d867c0b69ff67a90e6b542eac054
Submitter: Jenkins
Branch: master

commit f3a62d5ca304d867c0b69ff67a90e6b542eac054
Author: Ellen Hui <email address hidden>
Date: Tue Jun 10 00:24:49 2014 +0000

    Add node id to DEBUG messages in impitool

    Change-Id: Ic421350c4c5f8278ac020ee6a521026960e88634
    Closes-Bug: #1319637

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.