Deletion of stack containing server fails

[Paul Van Eck]

If you try to create a stack containing a server, the deletion of the stack will fail due to an attribute error:

Stack Trace:

2014-05-14 10:33:42.246 ERROR heat.engine.resource [-] Delete Server "Server" [de9a27c0-eddf-44b3-87ff-7074f65ff48f] Stack "tempstack3" [ec50c901-ee37-4c78-8393-4ef035fc32bd]
2014-05-14 10:33:42.246 TRACE heat.engine.resource Traceback (most recent call last):
2014-05-14 10:33:42.246 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 671, in delete
2014-05-14 10:33:42.246 TRACE heat.engine.resource handle_data = self.handle_delete()
2014-05-14 10:33:42.246 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resources/server.py", line 951, in handle_delete
2014-05-14 10:33:42.246 TRACE heat.engine.resource delete(wait_time=0.2)
2014-05-14 10:33:42.246 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/scheduler.py", line 142, in __call__
2014-05-14 10:33:42.246 TRACE heat.engine.resource self.run_to_completion(wait_time=wait_time)
2014-05-14 10:33:42.246 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/scheduler.py", line 204, in run_to_completion
2014-05-14 10:33:42.246 TRACE heat.engine.resource while not self.step():
2014-05-14 10:33:42.246 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/scheduler.py", line 190, in step
2014-05-14 10:33:42.246 TRACE heat.engine.resource next(self._runner)
2014-05-14 10:33:42.246 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resources/nova_utils.py", line 306, in delete_server
2014-05-14 10:33:42.246 TRACE heat.engine.resource refresh_server(server)
2014-05-14 10:33:42.246 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resources/nova_utils.py", line 67, in refresh_server
2014-05-14 10:33:42.246 TRACE heat.engine.resource if exc.code in (500, 503):
2014-05-14 10:33:42.246 TRACE heat.engine.resource AttributeError: 'NotFound' object has no attribute 'code'

This issue is causing neutron-heat-slow jobs to fail, as some test classes cannot be successfully torn down in the tearDownClass.
The cause of this issue stems from a change in a variable name as seen in a recent python-novaclient patch: https://review.openstack.org/#/c/69837/
Here you can see that the attribute 'code' that heat expects was changed to 'http_status'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/93696

[Steve Baker (steve-stevebaker)]

Marking as critical, this is causing race gate failures

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/93696
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=32f25e6fdddc66c59a16623e3d23dd09a5e79622
Submitter: Jenkins
Branch: master

commit 32f25e6fdddc66c59a16623e3d23dd09a5e79622
Author: Sergey Kraynev <email address hidden>
Date: Thu May 15 06:58:14 2014 -0400

    Using correct attribute of exception

    Currently patch (https://review.openstack.org/#/c/69837/6) was merged in
    python-novaclient. New exceptions have not attribute 'code' and now we
    should use http_status instead, falling back to the old attribute if
    the new attribute does not exist.

    Change-Id: I16e54c8e19dd93229fd7bcfe124fd4f2595f4e59
    Closes-bug: #1319499

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/95919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/95919
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e63baf60642a08c6f552b570e850f0df3b21a75d
Submitter: Jenkins
Branch: stable/icehouse

commit e63baf60642a08c6f552b570e850f0df3b21a75d
Author: Sergey Kraynev <email address hidden>
Date: Thu May 15 06:58:14 2014 -0400

    Using correct attribute of exception

    Currently patch (https://review.openstack.org/#/c/69837/6) was merged in
    python-novaclient. New exceptions have not attribute 'code' and now we
    should use http_status instead, falling back to the old attribute if
    the new attribute does not exist.

    Change-Id: I16e54c8e19dd93229fd7bcfe124fd4f2595f4e59
    Closes-bug: #1319499