[systest] Change simple sleep in 'setup_environment' method to wait

Bug #1319071 reported by Andrey Sledzinskiy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Kirill Omelchenko

Bug Description

I think we should change 'setup_environment' method in fuelweb_test/models/environment.py
We use simple sleep after starting admin node
self.get_virtual_environment().start(self.nodes().admins)
        # update network parameters at boot screen

        time.sleep(float(settings.ADMIN_NODE_SETUP_TIMEOUT))

        admin.send_keys(self.get_keys(admin))
        # wait while installation complete
        admin.await(self.admin_net, timeout=10 * 60)

It makes possible situation when sleep timeout isn't enough for starting admin node and settings from here admin.send_keys(self.get_keys(admin)) goes nowhere and it will cause setup failure

1. Change sleep on wait for condition - can be checking online state of admin node
2. Add logs

Tags: system-tests
Changed in fuel:
status: New → Confirmed
Dmitry Ilyin (idv1985)
summary: - [System tests] Change simple sleep in 'setup_environment' method to wait
+ [systest] Change simple sleep in 'setup_environment' method to wait
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Kirill Omelchenko (komelchenko)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109277

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/109277
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=d821b6db1d82094021a084f7c04bf5a81dcbb75c
Submitter: Jenkins
Branch: master

commit d821b6db1d82094021a084f7c04bf5a81dcbb75c
Author: Kirill Omelchenko <email address hidden>
Date: Thu Jul 24 15:29:01 2014 +0300

    Change sleep method to wait in 'setup_environment'

    Changed simple sleep timeout to wait.

    Change-Id: I3c95490fdd425b409292ce9550d3817d22c2caca
    Closes-Bug: #1319071

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (stable/5.0)

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/112833

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (stable/5.0)

Reviewed: https://review.openstack.org/112833
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=5f5dcd04a296387baff66550daa9294445610e33
Submitter: Jenkins
Branch: stable/5.0

commit 5f5dcd04a296387baff66550daa9294445610e33
Author: Kirill Omelchenko <email address hidden>
Date: Thu Jul 24 15:29:01 2014 +0300

    Change sleep method to wait in 'setup_environment'

    Changed simple sleep timeout to wait.

    Change-Id: I3c95490fdd425b409292ce9550d3817d22c2caca
    Closes-Bug: #1319071
    (cherry picked from commit d821b6db1d82094021a084f7c04bf5a81dcbb75c)

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.