destructive make clean-docker

[Aleksandra Fedorova]

Right now 'make clean-docker' is a very dangerous thing to perform. It erases all docker containers on the host system.

https://github.com/stackforge/fuel-main/blob/master/mirror/docker/module.mk

In use cases where we have several parallel builds running on the same server, or if we use those scripts in developer environment, it is rather easy to occasionally delete images completely unrelated to the Fuel ISO.

Can we restrict this erase command to some subset/pool or something? Maybe keep a list of Fuel containers? Name them in a certain predefined way?

[Aleksandra Fedorova (bookwar)]

Related to https://bugs.launchpad.net/fuel/+bug/1318633

[Bogdan Dobrelya (bogdando)]

Here is the list of images I have at the node after a single ISO build run:
REPOSITORY TAG
fuel/rsyslog_5.0 latest
fuel/postgres_5.0 latest
fuel/rabbitmq_5.0 latest
fuel/rsync_5.0 latest
fuel/ostf_5.0 latest
fuel/nginx_5.0 latest
fuel/nailgun_5.0 latest
fuel/mcollective_5.0 latest
fuel/cobbler_5.0 latest
fuel/astute_5.0 latest
busybox latest
centos centos6
centos latest
centos 6.4

Nothing in docker ps -a, though.
So yes, the solution should be to ensure only build related images and containers should be removed somehow...

[Matthew Mosesohn (raytrac3r)]

Alexandra, can you confirm e09af324dac1951d2a4a9098346e317d861daaca from May 12 to fuel-main is sufficient? I don't think we can do any better at this time without adding granular cleans during build itself.

[Aleksandra Fedorova (bookwar)]

I've made adjustments in Jenkins configuration for iso jobs. They won't run in parallel on the same node.

And this fix should limit the destructiveness of the script on developers machines, thus i'll mark it fixed