nova boot --number-instances with v4-fixed-ip

[Lawrance]

we can not run multi instances with v4-fixed-ip, as we know , the special ip can only belong to one instance, so i think while we specific the v4-fixed-ip, we could't use --num-instances .

HOW to reproduce:

nova boot --image cirros --flavor 1 --num-instances 2 --nics net-id=759e99ad...,v4-fixed-ip=10.0.0.17 instance001

[xuan.mingyi (xuan-mingyi)]

I think it should reports an error msg

[Aaron Rosen (arosen)]

I agree, I think we should raise an error message if --num-instances > 2 && v4-fixed-ip are used in conjunction.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/94691

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/94691
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1181d5e65f5488bdd147ef28ffe3e14c09862cec
Submitter: Jenkins
Branch: master

commit 1181d5e65f5488bdd147ef28ffe3e14c09862cec
Author: Aaron Rosen <email address hidden>
Date: Wed May 21 11:15:20 2014 -0700

    Prevent max_count > 1 and specified ip address as input

    Previously, if one did:
       nova boot --num-instances 2 --nic net-id=<net_id>,v4-fixed-ip=10.0.0.17
    this would result in all of the instances failing to boot because neither
    nova-network or neutron allows multiple instances to have the same ip_address.
    This patch fixes this from occuring by checking for this and raising an error
    to the caller from nova-api.

    Change-Id: I7e44d58e66aeb10fb15c3553072f988f65ab823b
    Closes-bug: 1318754

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/155608

[OpenStack Infra (hudson-openstack)]

Change abandoned by yanheven (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/155608
Reason: this is a 'medium' bug, and I don't think it deserves a higher level, since the bug is hit due to human error (partly). This means that it is not an appropriate commit for Icehouse, since Icehouse is in Support II Phase, which means only critical and security bug fixes are acceptable.