keylock fails with more than 50% of pitch

Bug #1318272 reported by Leo Combes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Undecided
Unassigned

Bug Description

The keylock is deactivated when exceed 50%

how to to reproduce the fails:
go to settings -> interface -> pitch slider range and select any value greater than 50%.
load a song
play it
raise the pitch exceeding 50%

system:
mixxx 1.12.0-alpha (build master r4416)
Linux Mint 16 x64

Tags: keylock pitch
Revision history for this message
Owen Williams (ywwg) wrote :

At high rates of speed, the keylock engine doesn't sound very good and we fall back to linear scaling. That threshold is currently 50%, so that's why you're hearing this. Since we do offer crazy-high pitch slider values, I'll change the constant to 1.91 instead of 1.5.

Changed in mixxx:
status: New → Fix Committed
Revision history for this message
Owen Williams (ywwg) wrote :

Verified that the fix works. It sounds pretty silly, but if someone really wants 190% speed, they can have it :)

Revision history for this message
Leo Combes (combesl) wrote :

three word for you:
EX - CE - LENT!

Is useful in some cases, but most importantly, it has a more predictable behavior.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 2.0.0
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7469

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.