InstanceActionEvent traceback parameter not serializable

[Hans Lindgren]

The change to use InstanceActionEvent objects in compute.utils.EventReporter changed the order of how things are done. Before, traceback info were converted to strings before being sent to the conductor. Now, since the object method being used remotes itself, the order becomes the opposite and any captured tracebacks are sent as is, resulting in errors during messaging.

See http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiVmFsdWVFcnJvcjogQ2lyY3VsYXIgcmVmZXJlbmNlIGRldGVjdGVkXCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6IjkwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6eyJ1c2VyX2ludGVydmFsIjowfSwic3RhbXAiOjEzOTk2MjYzMjYwODZ9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/93017

[Hans Lindgren (hanlind)]

Looks like most jobs don't fail due to this, so setting to high instead of critical.

[Matt Riedemann (mriedem)]

Confirming that this is juno only given the change mentioned that broke it is this:

https://review.openstack.org/92826

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/93017
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=59a6cf233b538d6666740de4796fce25ed8265aa
Submitter: Jenkins
Branch: master

commit 59a6cf233b538d6666740de4796fce25ed8265aa
Author: Hans Lindgren <email address hidden>
Date: Fri May 9 10:47:17 2014 +0200

    Fix InstanceActionEvent traceback parameter not serializable

    The change to use InstanceActionEvent in compute.utils.EventReporter
    changed the order of how things are done. Before, traceback info were
    converted to a string before being sent to the conductor. Now, since
    the object method being used remotes itself, the order becomes the
    opposite and any captured tracebacks are sent as is, resulting in
    errors during messaging.

    This adds a serialize_args decorator for this case, which handles
    this specific case for the event_finish_with_failure() classmethod.
    A more generic approach is needed, and that will be applied to the
    also-affected but currently-unused finish_with_failure() instance
    method.

    Change-Id: Ibedddd606b9d25ffbbb2b1b5358cf0aa4741083f
    Co-Authored-By: Dan Smith <email address hidden>
    Closes-Bug: #1317804