tox -epep8 fails in trove due to missing gettext pkg

[Peter Stachowski]

A change introduced to check the validity of po/pot files (https://review.openstack.org/#/c/84239 ) has the side-effect of requiring the msgfmt utility, found in the gettext pkg. We need to include this in redstack install, or running 'tox -epep8' in the trove project will result in an error:

ERROR: InvocationError: "/bin/bash -c find trove -type f -regex '.*\\.pot?' -print0 | xargs -0 -n 1 msgfmt --check-format -o /dev/null"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/92917

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/92917
Committed: https://git.openstack.org/cgit/openstack/trove-integration/commit/?id=72e7a6bf9da9fac87282b4eab2318263725a9d40
Submitter: Jenkins
Branch: master

commit 72e7a6bf9da9fac87282b4eab2318263725a9d40
Author: Peter Stachowski <email address hidden>
Date: Thu May 8 17:16:55 2014 -0400

    Added gettext to install_prep_packages

    To verify the validity of po/pot files, there is now a dependency
    on the msgfmt utility found in the gettext package.
    (This was introduced by https://review.openstack.org/#/c/84239 )

    The gettext package has therefore been added to the redstack
    install_prep_packages function.

    Change-Id: Iba6688dc3ef77ce6669253115d70a908f089ccd6
    Closes-Bug: #1317652

[Mike Spreitzer (mike-spreitzer)]

Hey, don't we have to fix all installs, not just redstack?

[Peter Stachowski (peterstac)]

That could very well be true. This was caused by a change to redstack though, so I thought it was local to it. If devstack needs to be fixed instead, maybe it should be done there. I don't recall seeing people complain that devstack was broken though ...

[Nikhil Manchanda (slicknik)]

OpenStack Infra isn't broken since I believe their Puppet scripts take care of ensuring this is installed on every devstack-gate node.