disk volume labels on conductor can conflict with nodes disk labels

[Chris Krelle]

If a nodes disk has the same volume labels as the conductor and those volumes are mounted on the conductor parted will fail to partition the nodes disk.

the error was found trying to rebuild a node using TripleO seedvm and a Dib generated user image. Both the seed vm and node vm had the " cloudimg-rootfs " label. this causes parted to give the error "Error: Partition(s) on /dev/sdb are being used." and there by fail to redeploy the node.

as a test I logged in to the node manually and ran e2label and gave the node unique labels logged out and rebuild worked as expected.

[Robert Collins (lifeless)]

This may mean reverting the use of parted :)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/93133

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97590
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=b0d7c1d87e824cb9cbd92271dc3db606e0e7530a
Submitter: Jenkins
Branch: master

commit b0d7c1d87e824cb9cbd92271dc3db606e0e7530a
Author: Chris Krelle <email address hidden>
Date: Tue Jun 3 13:08:55 2014 -0600

    Rework make_partitions logic when preserve_ephemeral is set

    This patch reworks the logic around make_partitions when rebuilding an
    instance with preserve_ephemeral set to true. The reworked logic will
    no longer wipe the current partitions when rebuilding an instance with
    preserve_ephemeral set.

    Partial-Bug: 1317647
    Change-Id: I15fc0d6323698eaa4c30b8aaa7fb740f51c035bc

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/93133
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=583d1a8e071186cf4f4051083ed60a9bcd52ba7c
Submitter: Jenkins
Branch: master

commit 583d1a8e071186cf4f4051083ed60a9bcd52ba7c
Author: Chris Krelle <email address hidden>
Date: Fri May 9 16:25:36 2014 -0400

    Wipe any metadata from a nodes disk

    Ensure that a nodes disk is wiped of any metadata. This Patch only
    deals with the wiping of the metadata per review comments.

    Closes-Bug: #1317647

    Change-Id: I3bc2da3a12362bad12957d6f34e7ee7807813300