dhcpchecker does not always receive message from dhcp relay

[Dima Shulyak]

Dhcpchecker doesnot always receives responses from dhcp relay on first dhcpdiscover.

Debugging shows that waiting longer doesnot solves problem, but sending second discover after some time helps to receive dhcpoffer. Seems that dhcp relay can be configured to precache leased ip addresses before sending them back to host, because offers from dhcp relay on master node is always received.

Some tweaking of dhcpcheck tool is required, probably creating series of dhcpdiscovers with timeouts between them

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/94162

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/94162
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=5b713f01229ccb78d68aa614d68535f5b4ddf7d8
Submitter: Jenkins
Branch: master

commit 5b713f01229ccb78d68aa614d68535f5b4ddf7d8
Author: Dima Shulyak <email address hidden>
Date: Mon May 19 13:21:54 2014 +0300

    Add repeat option to dhcp check

    repeat option was disabled when there was no tests for dhcp checker

    Repeat logic:

    send discover -> wait -> send -> wait

    Keep in mind that it does not stop when first dhcp offer is received,
    so for example if 3 repeat with timeout 10 will be set - it will run atleast for 30 seconds

    It does not affect current deployment because of usage repeat=1
    in net_probe.rb

    Change-Id: I9deec4d9bf9ef648518c678218e2460d3170bec3
    Related-Bug: #1320834
    Related-Bug: #1317525

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/102256

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/102256
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=6c2c8726d6d7ea739013af1b63d1746b0070edc2
Submitter: Jenkins
Branch: master

commit 6c2c8726d6d7ea739013af1b63d1746b0070edc2
Author: Dima Shulyak <email address hidden>
Date: Tue Jun 24 17:31:52 2014 +0300

    Send 3 dhcp discover packets

    One sended dhcp discover packet is not always enough to
    ensure answer from dhcp server

    Change-Id: I6b9351d98eea624c61964b152e3f7aa2755eeaaa
    Closes-Bug: #1317525