Defect: solum.worker.handlers.shell does not surface build failure

[Adrian Otto]

If solum.worker.handlers.shell gets a value of 'created_image_id=' returned from the shell command, the build has failed.

Expected Result: The status of the ASSEMBLY should be set to ERROR, and an error message with the shell command (including environment variables) to reproduce the error should be logged so the administrator can determine the cause of the problem.

Actual Result: The status of the assembly remains BUILDING forever. Example:

2014-05-07 01:54:56.021 5233 DEBUG solum.worker.handlers.shell [req-6276baf6-3d25-419c-a239-d47831a22bbc] sbuild id:1 COMPLETE (built successfully) 1 {'instance_uuid': None, 'read_only': False, 'domain': None, 'show_deleted': False, 'roles': [u'Member', u'_member_', u'solum_assembly_update', u'heat_stack_owner', u'anotherrole'], 'user_identity': '4c60aa90a97845299da12d9136ede077 7b242b69cdea4194a3ca7592ba7e57aa - default default', 'project_domain': u'default', 'assembly_id': 1, 'build_out_line': 'created_image_id=', 'is_admin': False, 'build_cmd': u'/opt/stack/solum/contrib/lp-cedarish/docker/build-app https://github.com/paulczar/example-nodejs-express.git nodeus 7b242b69cdea4194a3ca7592ba7e57aa auto', 'auth_url': None, 'user_domain': u'default', 'user_name': u'demo'} job_update_notification /opt/stack/solum/solum/worker/handlers/shell.py:38

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92515

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/92515
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=4b67ff4d53652cc360b795b611a08cbe3d0b2bd8
Submitter: Jenkins
Branch: master

commit 4b67ff4d53652cc360b795b611a08cbe3d0b2bd8
Author: Angus Salkeld <email address hidden>
Date: Wed May 7 14:36:24 2014 +1000

    Make sure we have a real created_image_id

    We sometimes get enough junk that makes the created_image_id look
    real. Use uuidutils to look for a proper uuid.

    Change-Id: Ia5528d39c4e71ab302d3634c1186cdcb390b8bb1
    Fixes-bug: #1316879