Describe use of preset folder next to the Open buttons

[Daniel Schürmann]

It is pretty unclear where to store the downloaded files.

[jus (jus)]

Agree, we should make it more clean what the different folders are good for.
And why are two of them /controllers and the other /presets? Legacy <> new?

[Karan Sanwal (karansanwal)]

I would like to try my luck with this bug, but can it be made clear on what needs to be done ?
Thanks !

[Daniel Schürmann (daschuer)]

This focuses on streamlining the use of midi mapping downloaded from the forums.
The Midi mapping dialogs should be made more self explaining. Do you have access to a DJ controller? If not, this might be hard to fix it right.

[Karan Sanwal (karansanwal)]

Sadly, I don't have the access to a DJ controller. So i cannot work on this.

[Emile V (emile-vrijdags)]

Hi,

I looked at this, and I would like to try to make it better.

To make sure I understand what needs to be done:
- Now there are 3 buttons which open 3 folders where controller presets can be saved.
 2 of these folders have the same parent path (in the users folder) and when I look closer to the code, seem to serve exactly the same function with the difference that one is called "/presets/" and the other "/controllers/". There is also one that functions as a user independent preset folder, which is also called "/controllers/".
So I would like to at least remove one button of the user specific paths, preferably the one pointing to "/presets/" and add a description why the user would want to put his downloaded presets in a folder.
I already did this in qt and a screenshot is attached (the 2 buttons are now smaller, and I put a label next to them with a description)

Now remains the question if this user "/preset/" folder can disappear all together in the code or maybe it serves a legacy function?
The legacy functionality doesn't seem very important to me, just moving the preset files to the new folder would fix any problem afaik, which seems straightforward, and removing all references in code seems the cleanest option.
Another option is to add some comments in the code to indicate why the 2nd folder is in there, however at some point it should probably be removed, so why not now?

What should I do?
Am I forgetting something?

[Emile V (emile-vrijdags)]

attachements dont seem to work I though they would, uploaded the screenshot of what I propose to do:
http://i.imgur.com/fwhwxK0.png

I see now I should probably add a "the" in both sentences: " Save *the* preset file(s).."

[jus (jus)]

Thanks for working on the bug, Emile.
You should go ahead and submit a pull request with your fixes on Github, see http://mixxx.org/wiki/doku.php/bugfix_workflow

[Emile V (emile-vrijdags)]

Thx for the feedback, I created a pull request:

https://github.com/mixxxdj/mixxx/pull/599

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7466