ironic.nova.driver.ClientWrapper lacks in unittest

Bug #1316549 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Lucas Alvares Gomes

Bug Description

There's no directly unittest for the ClientWrapper class, we need to add it

Changed in ironic:
importance: Undecided → Medium
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/92384

Changed in ironic:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/92416

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/92384
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=b09d98fe94ffc907dc749e6983e3b4f3b9863990
Submitter: Jenkins
Branch: master

commit b09d98fe94ffc907dc749e6983e3b4f3b9863990
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue May 6 12:20:49 2014 +0100

    Pass kwargs to ClientWrapper's call() method

    As the ClientWrapper class had no unittests some were added to test
    the specific part of the code for this change. The FakeClient() and
    associated classes from test_driver.py were moved to a common file to
    make it easier to be imported and used by the new unittests.

    Partial-bug: #1316549
    Related-bug: #1309719
    Change-Id: I11be25a6ce981e63027073d12fbf2922896f4693

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/92416
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=13e5b46ab898ab9a1a81552ef5fb6b3e601154e6
Submitter: Jenkins
Branch: master

commit 13e5b46ab898ab9a1a81552ef5fb6b3e601154e6
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue May 6 18:21:21 2014 +0100

    Add the remaining unittests to the ClientWrapper class

    This patch also pep8-fy the imports in the test_client_wrapper.py.

    Closes-Bug: #1316549
    Change-Id: Iaf154886c5c05f94ac045fbc99f93915bb91c878

Changed in ironic:
status: In Progress → Fix Committed
Changed in ironic:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.