Big Switch: servermanager HTTPS fails on 2.6

Bug #1316382 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kevin Benton
Icehouse
Fix Released
High
Kevin Benton

Bug Description

The HTTPS class with certificate validation in the Big Switch server manager module references a source_address attribute that isn't present in the python 2.6 httplib.

Tags: bigswitch
Revision history for this message
Kevin Benton (kevinbenton) wrote :
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
tags: added: folsom-backport-potential
tags: added: icehouse-backport-potential
removed: folsom-backport-potential
Changed in neutron:
status: New → In Progress
tags: added: bigswitch
Changed in neutron:
importance: Undecided → High
milestone: none → juno-1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/92276
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0dde14c0cd6ffea8ebff715342852ef17a9c0b70
Submitter: Jenkins
Branch: master

commit 0dde14c0cd6ffea8ebff715342852ef17a9c0b70
Author: Kevin Benton <email address hidden>
Date: Mon May 5 18:57:46 2014 -0700

    Big Switch: Check source_address attribute exists

    Check that the source_address attribute exists on
    HTTPSConnection objects before referencing it since
    it's not present on python 2.6 deployments.

    Closes-Bug: #1316382
    Change-Id: Id82e70f124cba73c33737099027b5c61aea713bb

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/92520

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/92930

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/92938

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/92930
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c33013c46a6d66768f585a2570be99d1b2ee85fb
Submitter: Jenkins
Branch: master

commit c33013c46a6d66768f585a2570be99d1b2ee85fb
Author: Kevin Benton <email address hidden>
Date: Thu May 8 15:47:31 2014 -0700

    Revert "Big Switch: Check source_address attribute exists"

    This reverts commit 0dde14c0cd6ffea8ebff715342852ef17a9c0b70.

    This fix only addressed part of the problem. The socket call
    in python 2.6 does not accept an extra source address arg
    either.

    Change-Id: I4df4f66e9db0da1a8923ee37e918718f3bcf26ee
    Partial-Bug: #1316382

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/92938
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f5e4cf8e3edd1ce0ebb8c0c7256be07d094896de
Submitter: Jenkins
Branch: master

commit f5e4cf8e3edd1ce0ebb8c0c7256be07d094896de
Author: Kevin Benton <email address hidden>
Date: Thu May 8 16:33:06 2014 -0700

    Big Switch: Check source_address attribute exists

    Check that the source_address attribute exists on
    HTTPSConnection objects before referencing it since
    it's not present on python 2.6 deployments. If it
    does not exist, create a socket connection without
    specifying the source.

    Closes-Bug: #1316382
    Change-Id: Ica10d23cc6de81ae56f711937f208c7321c77f36

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/93118

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/93118
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=26a591af18ea2bbbfcb69a6e48da5d8ad360146d
Submitter: Jenkins
Branch: stable/icehouse

commit 26a591af18ea2bbbfcb69a6e48da5d8ad360146d
Author: Kevin Benton <email address hidden>
Date: Thu May 8 16:33:06 2014 -0700

    Big Switch: Check source_address attribute exists

    Check that the source_address attribute exists on
    HTTPSConnection objects before referencing it since
    it's not present on python 2.6 deployments. If it
    does not exist, create a socket connection without
    specifying the source.

    Closes-Bug: #1316382

    Conflicts:

     neutron/tests/unit/bigswitch/test_servermanager.py

    Change-Id: Ica10d23cc6de81ae56f711937f208c7321c77f36
    (cherry picked from commit f5e4cf8e3edd1ce0ebb8c0c7256be07d094896de)

tags: added: in-stable-icehouse
Alan Pevec (apevec)
tags: removed: icehouse-backport-potential in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.