ValueError when cookie pagesize is ""

Bug #1316331 reported by Matthew D. Wood
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Matthew D. Wood

Bug Description

If a user somehow gets the value of 'horizon_pagesize' set to "", the method horizon.utils.functions.get_page_size will raise a ValueError because it can't convert the empty string to an int. Clearly this would also happen if the value gets set to any other non-valid int-literal.

Changed in horizon:
assignee: nobody → Matthew D. Wood (woodm1979)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/92219

Changed in horizon:
status: New → In Progress
Julie Pichon (jpichon)
Changed in horizon:
importance: Undecided → Medium
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/92219
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=736dff72581fbb5a56fc48944a4c1981125863ec
Submitter: Jenkins
Branch: master

commit 736dff72581fbb5a56fc48944a4c1981125863ec
Author: woodm1979 <email address hidden>
Date: Mon May 5 16:28:01 2014 -0600

    ValueError when cookie pagesize is empty string

    If a user somehow gets the value of 'horizon_pagesize' set to "", the
    method horizon.utils.functions.get_page_size will raise a ValueError
    because it can't convert the empty string to an int. Clearly this would
    also happen if the value gets set to any other non-valid int-literal.

    Change-Id: I4b1dd07df75d931f8c61823c93c5dd6ecc145686
    Closes-Bug: 1316331

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.