Deployment notification missing environment name

[Ryan Moe]

After a successful deployment the success message (and notification) says "Deployment of environment '1' is done." or whatever the current cluster_id is instead of the environment name.

{"build_id": "2014-04-30_17-19-03", "mirantis": "yes", "build_number": "172", "ostf_sha": "134765fcb5a07dce0cd1bb399b2290c988c3c63b", "nailgun_sha": "73dbfa9186bde292bdcc9b53bdf9cf99af5710ac", "production": "docker", "api": "1.0", "fuelmain_sha": "7ee582075c0fc4081a9d7bc82e76b4cb1214a834", "astute_sha": "3cffebde1e5452f5dbf8f744c6525fc36c7afbf3", "release": "5.0", "fuellib_sha": "fa257380eb6202ac528b3abb76755e6e5db79c77"}

[Dmitry Pyzhov (dpyzhov)]

It was done by purpose: https://bugs.launchpad.net/fuel/+bug/1291401

[Mike Scherbakov (mihgen)]

Then it has to be changed. It is not user-friendly to show internal cluster_id, which is not shown anywhere else. If we are about to choose between 'show cluster_id' vs don't show anything at all, I would vote for the second one.

Also, I think it was pretty informative to show environment name, and it's kept in notifications. Cases when env is renamed is much more rare. If we still want to care about inconsistency between renamed env and notification with old name , then we simply need to call Nailgun for changing env_name in notification. Basically it can be done by changing notification handler to always construct returned output from two DB fields:
"Deployment of environment '" + cluster.name + "' is done....". We can refresh panel using JS then to show panel with updated name.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/92796
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=ff6e315a4ac5983628ac24a1d2ccfe4534264ad3
Submitter: Jenkins
Branch: master

commit ff6e315a4ac5983628ac24a1d2ccfe4534264ad3
Author: Dmitry Pyzhov <email address hidden>
Date: Thu May 8 09:06:39 2014 +0000

    Revert "Environment name removed from deployment message"

    This reverts commit fe6bb13f604d87253eaf3210ea9920ceaaa6070b.

    Closes-Bug: #1316301
    Change-Id: I61979d4a8247294c9af0b851ab42d6a7910b8031

[Andrey Sledzinskiy (asledzinskiy)]

verified on {"build_id": "2014-05-22_01-10-31", "mirantis": "yes", "build_number": "216", "ostf_sha": "5c479f04c35127576d35526650ec83b104f9a33d", "nailgun_sha": "31fcb161ff8d6bfb861b041467440752c0e9c537", "production": "docker", "api": "1.0", "fuelmain_sha": "dda9cff27999e74b80e8e6a9e665e7e9677ab994", "astute_sha": "9a0d86918724c1153b5f70bdae008dea8572fd3e", "release": "5.0", "fuellib_sha": "872b6a7a968b619a493ad46c504910020ea2edae"}