Exception on unauthorized user/pass/token
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mistral |
Fix Released
|
High
|
Leandro Ignacio Costantino |
Bug Description
( couldn't find mistral client launchpad )
When Mistral API fails to authenticate against keystone:
2014-05-05 16:48:52.479 30993 WARNING keystoneclient.
2014-05-05 16:48:52.479 30993 WARNING keystoneclient.
2014-05-05 16:48:52.480 30993 INFO keystoneclient.
localhost - - [05/May/2014 16:48:52] "GET /v1/workbooks HTTP/1.1" 401 23
mistral-client return a ValueError exception since it's trying to decode as json the "Authorization Failed" message.
Changed in mistral: | |
status: | New → Confirmed |
Changed in mistral: | |
assignee: | nobody → Leandro Ignacio Costantino (leandro-i-costantino) |
milestone: | none → 0.1 |
importance: | Undecided → High |
no longer affects: | mistral/juno |
Changed in mistral: | |
milestone: | 0.1 → 0.0.4 |
Changed in mistral: | |
status: | Fix Committed → Fix Released |
Reviewed: https:/ /review. openstack. org/92198 /git.openstack. org/cgit/ stackforge/ python- mistralclient/ commit/ ?id=762e1cdc3c5 0b677555ef99207 cfdf3f609cdc3d
Committed: https:/
Submitter: Jenkins
Branch: master
commit 762e1cdc3c50b67 7555ef99207cfdf 3f609cdc3d
Author: Leandro I. Costantino <email address hidden>
Date: Mon May 5 16:55:33 2014 -0300
Return response as error if not valid json object
If the response returned by Mistral do not contain a valid json an
exception is thrown by the client due to invalid json format.
If there's a ValueError exception and it's an error code try to return
the response text instead. (Ex: Authorization Failed )
This may be a temporary fix if the BE is able to return the json
error msg returned by keystone.
Change-Id: I540f3aaa35fb15 adc04bf0a33e46a f8ac614c814
Closes-Bug: #1316298