Changing deletion policy update resource

Bug #1316171 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Thomas Herve

Bug Description

Updating the deletion policy updates the whole resource, which can lead to a delete/create, which seems unnecessary most of the time. It can lead to some stupid behavior when setting the deletion policy to Retain on a volume, as updating the stack deletes and recreates the volume.

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/92145

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/92145
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=65e068557df1d8d7ce04f7dbd37ef0f83a9bfe26
Submitter: Jenkins
Branch: master

commit 65e068557df1d8d7ce04f7dbd37ef0f83a9bfe26
Author: Thomas Herve <email address hidden>
Date: Mon May 5 17:37:56 2014 +0200

    Remove update_allowed_keys definition and usage

    The update_allowed_keys attribute didn't really define any useful
    policy, and prevented automatic update which should be handled by the
    base Resource class like DeletionPolicy. This patch removes the usage
    and the various definitions around the code base.

    Change-Id: I78494aba07b6badeca8e95f1875ca8e4b9b0290c
    Co-Authored-By: <email address hidden>
    Partial-Bug: #1316171

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/94615

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/94615
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=84640e7a7a6b563778a324ac99994cc0d4cb6871
Submitter: Jenkins
Branch: master

commit 84640e7a7a6b563778a324ac99994cc0d4cb6871
Author: Thomas Herve <email address hidden>
Date: Wed May 21 15:18:32 2014 +0200

    Only raise UpdateReplace when properties change

    This changes the default behavior of Resource.handle_update to only
    raise UpdateReplace if the properties are different. It allows updating
    DeletionPolicy cleanly without deleting the resource.

    Co-Authored-By: <email address hidden>
    Closes-Bug: #1316171
    Change-Id: I1d2864dc44ff7a5b4536b26f2dba525e01e56af0

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.